Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.jaeger-client: init 4.6.1 #139316

Merged
merged 4 commits into from Oct 22, 2021
Merged

python3Packages.jaeger-client: init 4.6.1 #139316

merged 4 commits into from Oct 22, 2021

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Sep 24, 2021

This PR is ready to be reviewed

--

Fixing:

  • python3Packages.zc_buildout: 2.13.4 -> 3.0.0b2

Adding:

  • python3Packages.jaeger-client: init 4.6.1
  • python3Packages.threadloop: init 1.0.2

I have simplified this PR. To avoid adding too many old python packages. Tests are disabled on purpose. (It is not out of laziness.)

This is a dependency of sygnal (#137092) and popped up as inner dependency at OpenStack too (where?), I had scrapped it at PR #136533 . As @Kloenk is in need of it, I'm offering it again.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 24, 2021

Result of nixpkgs-review pr 139316 at fb1b834f run on x86_64-linux 1

14 packages built successfully:
  • python38Packages.jaeger-client
  • python38Packages.martian
  • python38Packages.threadloop
  • python38Packages.z3c-checkversions
  • python38Packages.z3c_testsetup
  • python38Packages.zc_buildout
  • python38Packages.zest_releaser
  • python39Packages.jaeger-client
  • python39Packages.martian
  • python39Packages.threadloop
  • python39Packages.z3c-checkversions
  • python39Packages.z3c_testsetup
  • python39Packages.zc_buildout
  • python39Packages.zest_releaser

Result of nixpkgs-review pr 139316 at 0e527ec7 run on aarch64-linux 1

14 packages built successfully:
  • python38Packages.jaeger-client
  • python38Packages.martian
  • python38Packages.threadloop
  • python38Packages.z3c-checkversions
  • python38Packages.z3c_testsetup
  • python38Packages.zc_buildout
  • python38Packages.zest_releaser
  • python39Packages.jaeger-client
  • python39Packages.martian
  • python39Packages.threadloop
  • python39Packages.z3c-checkversions
  • python39Packages.z3c_testsetup
  • python39Packages.zc_buildout
  • python39Packages.zest_releaser

@superherointj superherointj changed the title pythonPackages.jaeger-client: init 4.6.1 python3Packages.jaeger-client: init 4.6.1 Sep 24, 2021
@superherointj superherointj marked this pull request as draft October 5, 2021 20:26
@SuperSandro2000
Copy link
Member

popped up as inner dependency at OpenStack too

If it is somewhat important/closely related to openstack please add it to the openstack team.

How do I deal with this?

Try to remove the package entirely. It is archived, obviously unmaintained for over 6 years and looks really unfinished, too.

threadloop # ImportError: cannot import name 'ThreadLoop' from 'threadloop' (Any clue?)

Also dead for 6 years. Maybe the tests try to import from a wrong location? I am not sure how well ztest works with nixpkgs yet.

@superherointj superherointj changed the title python3Packages.jaeger-client: init 4.6.1 [wip] python3Packages.jaeger-client: init 4.6.1 Oct 6, 2021
@superherointj
Copy link
Contributor Author

popped up as inner dependency at OpenStack too
If it is somewhat important/closely related to openstack please add it to the openstack team.

I don't remember exactly where. =/

Also dead for 6 years. Maybe the tests try to import from a wrong location? I am not sure how well ztest works with nixpkgs yet.

I have simplified this PR to avoid adding old python packages. It is for the better. Don't mind the lack of tests. It's a dreadful rabbit hole.

@superherointj superherointj marked this pull request as ready for review October 21, 2021 23:10
@superherointj superherointj changed the title [wip] python3Packages.jaeger-client: init 4.6.1 python3Packages.jaeger-client: init 4.6.1 Oct 21, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/613

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 139316 run on x86_64-linux 1

8 packages built:
  • python38Packages.jaeger-client
  • python38Packages.threadloop
  • python38Packages.z3c-checkversions
  • python38Packages.zc-buildout
  • python39Packages.jaeger-client
  • python39Packages.threadloop
  • python39Packages.z3c-checkversions
  • python39Packages.zc-buildout

@SuperSandro2000 SuperSandro2000 merged commit 2526c08 into NixOS:master Oct 22, 2021
@superherointj superherointj deleted the package-pythonPackages.jaeger-client-4.6.1-attempt2 branch October 22, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants