Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krita: 4.4.7 -> 4.4.8 + Add beta version 5.0.0-beta1 #139476

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Krita: 4.4.7 -> 4.4.8 + Add beta version 5.0.0-beta1 #139476

merged 1 commit into from
Oct 11, 2021

Conversation

sky1e
Copy link
Contributor

@sky1e sky1e commented Sep 25, 2021 •
edited
Loading

Motivation for this change

Update Krita package to latest stable patch version, as well as add a new variant of the package for the latest beta.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar September 25, 2021 21:03
@artemist
Copy link
Member

@GrahamcOfBorg build krita krita-beta
(I think I should be allowed to do this, let's see)

SuperSandro2000
SuperSandro2000 requested changes Sep 28, 2021
View reviewed changes
pkgs/applications/graphics/krita/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/krita/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/krita/default.nix Outdated Show resolved Hide resolved
@artemist artemist self-requested a review October 11, 2021 23:11
artemist
artemist approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@artemist artemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks resolved, LGTM

@yu-re-ka yu-re-ka merged commit cd78f8e into NixOS:master Oct 11, 2021
@sky1e sky1e deleted the krita-beta branch October 12, 2021 00:10
@sky1e sky1e mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemist artemist artemist approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sky1e @artemist @SuperSandro2000 @Janik-Haag @yu-re-ka