Update liquidsoap to 2.0.5

[dali99]

Motivation for this change

Liquidsoap no longer provides liquidsoap-full source, so all the savonet libraries must be packaged properly as libraries now.

Camomile's META file did not include a version, which is required for liquidsoap's configure step, so I added it.
Feel free to suggest a better way to accomplish this

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[dali99]

That should be all of the libraries documented on https://www.liquidsoap.info/doc-dev/build.html except:

• osx-secure-transport
• tsdl-image
• tsdl-tff

tdsl-image seems pretty abandoned and didn't compile for me

[dali99]

1 package failed to build:
ligo

6 packages built:
libbap liquidsoap python38Packages.bap python39Packages.bap reason shine

but then when I tried building ligo manually it worked so it was just flaky with nix-review for some weird reason

[ehmry]

Thanks for updating this, I tried earlier this year but gave up. I have some more ocalm packages that you might be able to use: master...ehmry:liquidsoap

[vbgl]

This huge PR will be a pain to review. Fortunately many changes are independent and can be reviewed and merged separately. Could you please split this PR into smaller pieces?

[Lassulus]

would be glad to see this merged. can you maybe fix the merge conflict and then we could check if anything fails and if not merge it?

[dali99]

There are unfortunately still things which don't work properly. I've been a little blocked for time lately but plan on moving some of the more obvious package upgrades/clean ups to separate prs like suggested before. Then we can merge liquidsoap with the modules that work and leave the rest as future work. I'm not happy with the hacks to get version numbers in as well and would like to get some feedback from somone with more ocaml experience as to what the proper solution would be.

…

On Thu, 3 Feb 2022, 16:32 Lassulus, ***@***.***> wrote: would be glad to see this merged. can you maybe fix the merge conflict and then we could check if anything fails and if not merge it? — Reply to this email directly, view it on GitHub <#140777 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHR4LYBZ3GDKW5VJCRRLHTUZKNYZANCNFSM5FPEK43A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[dali99]

Current status:

checking for ocaml posix-time2 module... Not found.
checking for ocaml curl module >= 0.9.2... requires version >= 0.9.2 found 0.9.1.
checking for ocaml memtrace module... Not found.
checking for ocaml mem_usage module... Not found.
checking for ocaml lastfm module >= 0.3.0... lastfm needs xmlplaylist curl
checking for ocaml osx-secure-transport module... Not found.
checking for ocaml tsdl-ttf module... Not found.
checking for ocaml tsdl-image module >= 0.3.2... Not found.
checking for ocaml cohttp-lwt-unix module... Not found.
checking for ocaml prometheus-app module... Not found.
checking for ocaml winsvc module... Not found.

* Liquidsoap
   - version           : 2.0.5

 * Supported input formats
   - MP3               : yes
   - AAC               : yes
   - FFmpeg            : yes
   - Flac (native)     : yes
   - Flac (ogg)        : yes
   - Lastfm            : no (requires lastfm)
   - Opus              : yes
   - Speex             : yes
   - Theora            : yes
   - Vorbis            : yes
   - XML playlists     : yes

 * Supported output formats
   - FDK-AAC           : yes
   - FFmpeg            : yes
   - MP3               : yes
   - MP3 (fixed-point) : yes
   - Opus              : yes
   - SPEEX             : yes
   - Theora            : yes
   - Vorbis            : yes

 * Tags
   - charset detection : yes
   - Taglib (ID3 tags) : yes
   - Vorbis            : yes

 * Input / output
   - ALSA              : yes
   - AO                : yes
   - FFmpeg            : yes
   - Icecast/Shoutcast : yes
   - GStreamer         : yes
   - JACK              : yes
   - OSS               : yes
   - Portaudio         : yes
   - Pulseaudio        : yes
   - SRT               : yes

 * Audio manipulation
   - FFmpeg            : yes
   - LADSPA            : yes
   - Lilv              : yes
   - Samplerate        : yes
   - SoundTouch        : yes

 * Video manipulation
   - camlimages        : yes
   - FFmpeg            : yes
   - frei0r            : yes
   - SDL-image         : no (requires tsdl-image)
   - SDL-ttf           : no (requires tsdl-ttf)

 * MIDI manipulation
   - DSSI              : yes

 * Visualization
   - GD                : yes
   - Graphics          : yes
   - SDL               : yes

 * Additional libraries
   - http requests     : no (requires curl)
   - FFmpeg filters    : yes
   - FFmpeg devices    : yes
   - dynlink           : yes
   - inotify           : yes
   - lastfm            : no (requires lastfm)
   - lo                : yes
   - magic             : yes
   - memtrace          : no (requires memtrace)
   - mem_usage         : no (requires mem_usage)
   - SecureTransport   : no (requires osx-secure-transport)
   - ssl               : yes
   - posix-time2       : no (requires posix-time2)
   - windows service   : no (requires winsvc)
   - yojson            : yes

 * Monitoring
   - Prometheus        : no (requires prometheus-app)

it not finding posix-time2 is quite surprising, if anyone has an idea of why please chime in.
I'll update curl and take one last look at packaging the tsdl stuff

[vbgl]

FWIW, tsdl libraries are available in nixpkgs. See: #175613

[Lassulus]

Result of nixpkgs-review pr 140777 run on x86_64-linux 1

5 packages built:

• google-drive-ocamlfuse
• libbap
• liquidsoap
• python310Packages.bap
• python39Packages.bap