patchutils: add 0.4.2 variant + remove meta.executable + enable tests + fix inter-dependencies by wrapping #141567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
changed the title
Artturin
changed the title
ofborg
bot
added
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
|
Result of 7 packages built successfully:
Result of 2 packages marked as broken and skipped:
17 packages failed to build:
1 package skipped due to time constraints:
7 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
Artturin
requested review from
bobvanderlinden,
edef1c,
timokau,
vcunat and
ajs124
and removed request for
bobvanderlinden
|
the packages which failed to build are pre-existing |
bobvanderlinden
approved these changes
Oct 17, 2021
There was a problem hiding this comment.
Ran the following which all succeeded. Confirmed that the verifyPhase also ran:
nix build .#patchutils
nix build .#patchutils_0_3_3
nix build .#patchutils_0_4_2
gitdiff of patchutils_0_4_2 ran succesfully:
result/bin/gitdiff 36802be8b12 bfe02b23205
File #1 a/pkgs/tools/text/patchutils/generic.nix
Confirmed that 0.4.2 is the latest version of patchutils.
Artturin
force-pushed
the
patchutilsbump
branch
from
76dc9d5
to
e3dc14d
Compare
Artturin
force-pushed
the
patchutilsbump
branch
from
e3dc14d
to
15e5ca6
Compare
Comment on lines
+503
to
+506
| fetchpatch = callPackage ../build-support/fetchpatch { } | ||
| // { | ||
| tests = callPackages ../build-support/fetchpatch/tests.nix { }; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| fetchpatch = callPackage ../build-support/fetchpatch { } | |
| // { | |
| tests = callPackages ../build-support/fetchpatch/tests.nix { }; | |
| }; | |
| fetchpatch = callPackage ../build-support/fetchpatch { } // { | |
| tests = callPackages ../build-support/fetchpatch/tests.nix { }; | |
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)