gmid: init at 1.7.5 #141659
Merged
gmid: init at 1.7.5 #141659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 1 package built:
|
WolfangAukang
approved these changes
Oct 24, 2021
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
r-burns
reviewed
Oct 24, 2021
Comment on lines
+18
to
+22
| configurePhase = '' | ||
| runHook preConfigure | ||
| ./configure PREFIX=$out | ||
| runHook postConfigure | ||
| ''; |
There was a problem hiding this comment.
Why not use configureFlags?
There was a problem hiding this comment.
configureFlags will be appended, but there is no way to remove some default flag, in this case we should not pass --prefix flag, otherwise configure script will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gmid is a fast Gemini server written with security in mind.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)