Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kicad-unstable: 2021-07-12 -> 6.0.0-rc1 #142261

Merged
merged 2 commits into from Nov 23, 2021
Merged

kicad-unstable: 2021-07-12 -> 6.0.0-rc1 #142261

merged 2 commits into from Nov 23, 2021

Conversation

evils
Copy link
Member

@evils evils commented Oct 19, 2021 •
edited

Motivation for this change

some library paths changed

RC1 was tagged

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Kiwi October 19, 2021 23:01
@newAM
Copy link
Member

newAM commented Oct 20, 2021

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build

@evils evils changed the title kicad-unstable: 2021-07-12 -> 2021-10-19 kicad-unstable: 2021-07-12 -> 2021-11-10 Nov 10, 2021
@artemist artemist self-requested a review November 12, 2021 22:01
artemist
artemist approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@artemist artemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footprints, symbols, and 3D symbols are all working and I'm able to open and edit designs, LGTM

@evils evils changed the title kicad-unstable: 2021-07-12 -> 2021-11-10 kicad-unstable: 2021-07-12 -> 6.0.0-rc1 Nov 16, 2021
@evils
Copy link
Member Author

evils commented Nov 16, 2021

updated this to 6.0.0-rc1

evils and others added 2 commits November 17, 2021 00:19
@evils
kicad-unstable: 2021-07-12 -> 2021-11-10
a11fa56 
with changes to library paths

Plugin and Content Manager seems to work
  (not related to the library paths changes)
@evils
kicad-unstable: 2021-11-10 -> 6.0.0-rc1
a340d8c
@benley benley merged commit decac5a into NixOS:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemist artemist artemist approved these changes

@newAM newAM newAM approved these changes

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evils @newAM @artemist @benley