Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-serif-pro: 3.000 -> 4.004, source-sans-pro: 3.006 -> 3.046, source-code-pro: 2.030 -> 2.038 #142434

Merged
merged 3 commits into from Oct 21, 2021
Merged

source-serif-pro: 3.000 -> 4.004, source-sans-pro: 3.006 -> 3.046, source-code-pro: 2.030 -> 2.038 #142434

merged 3 commits into from Oct 21, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 21, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from relrod and ttuegel October 21, 2021 00:51
@r-rmcgibbo
Copy link

r-rmcgibbo commented Oct 21, 2021 •
edited

Result of nixpkgs-review pr 142434 at 52b447d4 run on x86_64-linux 1

1 package failed to build:
2 packages built successfully:
  • source-code-pro
  • source-serif

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 142434 at 52b447d4 run on aarch64-linux 1

1 package failed to build:
2 packages built successfully:
  • source-code-pro
  • source-serif

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@SuperSandro2000 SuperSandro2000 merged commit f91b786 into NixOS:master Oct 21, 2021
@andersk andersk mentioned this pull request Oct 26, 2021
Closed
@andersk
Copy link
Contributor

andersk commented Oct 26, 2021

This seems to have completely broken the evaluation of nixos-unstable on Hydra: #142918.

@marsam marsam deleted the update-source-fonts branch May 31, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relrod relrod Awaiting requested review from relrod

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @r-rmcgibbo @andersk @SuperSandro2000