python38Packages.PyICU: 2.7.4 -> 2.8 #143838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icu68 was pinned in de8dbb2 for 21.05 ZHF, but it's no longer necessary.
jonringer
suggested changes
Oct 30, 2021
There was a problem hiding this comment.
regressions with normality tests, they look legitimate
https://github.com/NixOS/nixpkgs/pull/143838
6 packages failed to build:
python38Packages.fingerprints python38Packages.normality python38Packages.scancode-toolkit python39Packages.fingerprints python39Packages.normality python39Packages.scancode-toolkit
6 packages built:
gramps python38Packages.PyICU python38Packages.slob python39Packages.PyICU python39Packages.slob xdxf2slob
Upgrading normality to 2.2.3 doesn't help
__________________________ NormalityTest.test_german ___________________________
self = <tests.test_normality.NormalityTest testMethod=test_german>
def test_german(self):
text = u"Häschen Spaß"
> self.assertEqual("Haschen Spass", ascii_text(text))
E AssertionError: 'Haschen Spass' != 'Haschen Spa<-ss->'
E - Haschen Spass
E + Haschen Spa<-ss->
E ? ++ ++
tests/test_normality.py:48: AssertionErro
|
@GrahamcOfBorg build python3Packages.normality |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.PyICU is: "Python extension wrapping the ICU C++ API"
meta.homepage for python38Packages.PyICU is: "https://github.com/ovalhub/pyicu/"
meta.changelog for python38Packages.PyICU is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.testsdid not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 2.8 with grep in /nix/store/zkj1l0bk8g4x4p5ziad7mkvqwl26cz9a-python3.8-PyICU-2.8
found 2.8 in filename of file in /nix/store/zkj1l0bk8g4x4p5ziad7mkvqwl26cz9a-python3.8-PyICU-2.8
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-reviewrun on x86_64-linux 112 packages built:
Maintainer pings