Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.lean-nvim: add dependencies #144282

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Nov 2, 2021

Motivation for this change

Per https://github.com/Julian/lean.nvim/blob/1adf2c8fd323ea1758d1b3a5f78be6dd44592a6b/README.rst, the lean.nvim plugin has these two dependencies. I omitted any optional dependencies and the Lean language server from this addition.

Things done

When I added these packages manually to my home-manager setup, Vim fired up successfully and showed me the plugin's infoview pane; I haven't installed the Lean 3 language server so I couldn't get as far as testing whether anything actually works, but the language server is strictly speaking optional so I didn't go any further.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Smaug123
Copy link
Contributor Author

Smaug123 commented Nov 2, 2021

The PR which introduced lean-nvim is #143923 . @RaitoBezarius any views on this?

@RaitoBezarius
Copy link
Member

@Smaug123 Good point! I listed them explicitly myself because I am not sure, it's the good semantic to put them as hidden dependencies.

@Smaug123
Copy link
Contributor Author

Smaug123 commented Nov 2, 2021 via email

@RaitoBezarius
Copy link
Member

RaitoBezarius commented Nov 2, 2021 via email

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 144282 run on x86_64-linux 1

2 packages built:
  • spacevim
  • vimPlugins.lean-nvim

@jonringer jonringer merged commit 46bb154 into NixOS:master Nov 2, 2021
@Smaug123 Smaug123 deleted the lean-nvim-dep branch November 3, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants