Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_17: enable on x86_64-darwin #144644

Merged
merged 1 commit into from Nov 6, 2021
Merged

go_1_17: enable on x86_64-darwin #144644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkgs/development/compilers/go/1.17.nix
View file
Open in desktop
Expand Up @@ -273,7 +273,5 @@ stdenv.mkDerivation rec {
license = licenses.bsd3;
maintainers = teams.golang.members;
platforms = platforms.linux ++ platforms.darwin;
# requires >=10.13 stdenv on x86_64-darwin
badPlatforms = [ "x86_64-darwin" ];
};
}
10 changes: 4 additions & 6 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Expand Up @@ -20228,9 +20228,8 @@ with pkgs;
go = buildPackages.go_1_16;
};
# go_1_17 has go module changes which may not be portable
# across different go versions and/or platforms,
# it also requires >=10.13 stdenv on darwin which
# is not currently available for x86_64-darwin
# across different go versions and/or platforms:
# https://github.com/NixOS/nixpkgs/issues/144667
#
# do not uncomment this without approval from the go CODEOWNERS
#buildGo117Package = callPackage ../development/go-packages/generic {
Expand All @@ -20246,9 +20245,8 @@ with pkgs;
go = buildPackages.go_1_16;
};
# go_1_17 has go module changes which may not be portable
# across different go versions and/or platforms,
# it also requires >=10.13 stdenv on darwin which
# is not currently available for x86_64-darwin
# across different go versions and/or platforms:
# https://github.com/NixOS/nixpkgs/issues/144667
r-burns marked this conversation as resolved.
Show resolved Hide resolved
#
# do not uncomment this without approval from the go CODEOWNERS
#buildGo117Module = callPackage ../development/go-modules/generic {
Expand Down