Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomobile: make providing Android SDK optional #144748

Merged
merged 1 commit into from
Nov 9, 2021
Merged

gomobile: make providing Android SDK optional #144748

merged 1 commit into from
Nov 9, 2021

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Nov 5, 2021 •
edited
Loading

Motivation for this change

Currently there are no aarch64-darwin builds of Android SDK available.
For this reason attempts to build gomobile on that platform fail with:

No Android SDK tarballs are available for system architecture: aarch64-darwin

Tested in: status-im/status-mobile#12797

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@jakubgs jakubgs mentioned this pull request Nov 5, 2021
Open
@jakubgs
gomobile: make providing Android SDK optional
22c0c35 
Currently there are no `aarch64-darwin` builds of Android SDK available.
For this reason attempts to build `gomobile` on that platform fail with:
```
No Android SDK tarballs are available for system architecture: aarch64-darwin
```

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs
Copy link
Contributor Author

jakubgs commented Nov 8, 2021

@SuperSandro2000 any other fixes I can apply?

@SuperSandro2000 SuperSandro2000 merged commit 3e09ae9 into NixOS:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubgs @SuperSandro2000