New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chickenPackages_5.chicken: fix cross-compilation #145194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
chickenPackages.egg2nix fails with |
12a39f5
to
538c06c
Compare
$ nix log /nix/store/x503zkjmvxvhwz7y5dpd802gcnp6jyx6-chicken-5.2.0.drv | ix
http://ix.io/3Evw |
Did egg2nix already fail before? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure that it also works with clang / compilers with a different prefix.
Otherwise, LGTM.
Tested building chickenPackages_5.chicken
as native build and cross-compiled to aarch64-multiplatform
.
Tested both native version and cross version by running csi
(using qemu-aarch64 for the cross case). I don't know the language and haven't actually tried any expressions, but the interpreter seems to at least run.
"PREFIX=$(out)" | ||
"HOSTSYSTEM=${hostPlatform.config}" | ||
"TARGETSYSTEM=${targetPlatform.config}" | ||
"LIBRARIAN=$(HOSTSYSTEM)-gcc-ar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work without the -gcc
part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
538c06c
to
ee28fba
Compare
@Mindavi you can try |
if i do
then it fails with
|
Motivation for this change
Supersedes #104775
Things done
nix build ".#pkgsCross.aarch64-multiplatform.chicken"
nix build ".#chicken"
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)