New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copier: init at 7.0.1 #145528
copier: init at 7.0.1 #145528
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
]; | ||
|
||
# no tests include in sdist, and source not available | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream repo contains a couple of tests
.
jinja2 | ||
tomlkit | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests would be available if the source from GitHub is used.
pyyaml | ||
setuptools-scm | ||
setuptools-scm-git-archive | ||
toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be part of setuptools-scm actually.
Unfortunately it seems the main functionality of this package is broken atm, in a similar way as to when I made my attempt.
If you set up a simple template like so: mkdir my-template
cd my-template
echo "filename:
type: str
help: What's the name of the file?
default: myDefaultName
" > copier.yml
echo "Hi, I'm [[ filename ]]" > '[[ filename ]].txt.tmpl' and then run you should get a prompt requesting a value for When this package is used, versus the copier installed via |
This seems to be intended behavior https://github.com/copier-org/copier/blob/master/CHANGELOG.md#changed
One thing to note is that I'm packaging off their master since it's more coherent with the rest of python packages. Breaking changes won't be reflected. |
oh no... that means i might have had it in an actual working state before... my apologies, thank you, I at least for sure didn't properly package any of the dependencies for nix as you did here EDIT: After more testing, they changed the default template extension too from .tmpl to .jinja! I didn't even see that in the changelog! I will name one of my children after you |
Would be great if this could be merged! Thanks |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
related issue: mtkennerly/poetry-dynamic-versioning#62 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/help-building-pdm-based-python-package/18256/2 |
pkgs/tools/misc/copier/default.nix
Outdated
|
||
python3.pkgs.buildPythonApplication rec { | ||
pname = "copier"; | ||
version = "unstable-2021-11-10"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW Copier 6 was recently released. You'd probably prefer to package that?
83a144c
to
5809f2a
Compare
db05cbc
to
50710bf
Compare
Motivation for this change
Thought I would try my hand at packaging this, someone mentioned they had great difficulty doing so, and I would agree.
https://discourse.nixos.org/t/buildpythonpackage-throwing-dependency-version-errors-when-i-dont-belive-it-should-be/15818
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)