linuxPackages.rtl88xxau-aircrack: fix build for linux 5.15 #145697
Conversation
|
it compiles now after applying a upstream patch, don't have the hardware so can't test it running. Maybe some can do that? |
I saw the pattern of using the patch and decided to continue with it, just to get it compiling. Should we bump the version instead? |
This removes the unnecessary patches and bumps the version to the rev of tag v5.6.4.2 ZHF: NixOS#144627 Co-authored-by: nixinator <33lockdown33@protonmail.com>
MatthewCroughan
force-pushed
the
fix-rtl88xxau-aircrack
branch
from
e445dbb
to
df6bfa5
Compare
|
The latest tagged release does compiles successfully with a 5.15 kernel, though only if we remove the 5.12 kernel patch, so I have done this. |
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/145697
2 packages marked as broken and skipped:
linuxKernel.packages.hardkernel_4_14.rtl88xxau-aircrack linuxPackages_hardkernel_latest.rtl88xxau-aircrack
1 package failed to build:
linuxPackages_hardened.rtl88xxau-aircrack
18 packages built:
linuxKernel.packages.linux_4_14.rtl88xxau-aircrack linuxPackages_4_14_hardened.rtl88xxau-aircrack linuxKernel.packages.linux_4_19.rtl88xxau-aircrack linuxPackages_4_19_hardened.rtl88xxau-aircrack linuxKernel.packages.linux_4_4.rtl88xxau-aircrack linuxKernel.packages.linux_4_9.rtl88xxau-aircrack linuxPackages.rtl88xxau-aircrack linuxKernel.packages.linux_5_14.rtl88xxau-aircrack linuxPackages_5_14_hardened.rtl88xxau-aircrack linuxPackages_latest.rtl88xxau-aircrack linuxKernel.packages.linux_5_4.rtl88xxau-aircrack linuxPackages_5_4_hardened.rtl88xxau-aircrack linuxPackages_latest-libre.rtl88xxau-aircrack linuxPackages-libre.rtl88xxau-aircrack linuxPackages_lqx.rtl88xxau-aircrack linuxPackages_testing_bcachefs.rtl88xxau-aircrack linuxPackages_xanmod.rtl88xxau-aircrack linuxPackages_zen.rtl88xxau-aircrack
| @@ -20,14 +20,6 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| NIX_CFLAGS_COMPILE="-Wno-error=incompatible-pointer-types"; | |||
|
|
|||
| # Fix build for 5.12 kernels | |||
| patches = [ | |||
| (fetchpatch { | |||
There was a problem hiding this comment.
Please remove the unused fetchpatch from inputs.
|
there are quite a few of these out of tree wireless drivers that exhibit this problem. (due 5.15 kernel maintainers removing ipx for ever :-( ) https://hydra.nixos.org/build/157498591/nixlog/1 so all these drivers need bumping/patching too :-). how do we handle older kernels like 5.10.x , or is a 'nixos release' always tied to a 'supported kernel' and out of tree drivers need to follow the 'nixos release kernel version'???? |
|
linuxPackages_5_15.rtl8812au is source from https://github.com/gordboy/rtl8812au-5.9.3.2 however that doesn't compile of 5.15 , however https://github.com/morrownr/8812au-20210629 apparently does, however , do we swap over or make a new package for this driver? I've not got the hardware so hard to test, or leave it for some poor soul to fix later? |
Are both projects still maintained? Does the new project only build with new kernels?
If the original kernel maintainer has tested the code and it compiles we might not need to test it ourself. |
|
having looked at a few of these out of tree wireless drivers, the are quite a few repo's that seem to support the same things, so it's hard to get one source of truth. Many have patches to get them into the more 'exotic modes' of operation, like this driver for example. Although we have fairly good integration testing via Nixos tests , we need a test farm of real machines, connected to real hardware, to do bare metal nixos testing in realtime!... :-). I hear of projects in the embedded space, that do exactly that. You can but dream(2nix) of something like this one day. again, this is a just a build error (ipx.h removed from 5.15), which is a clear show stopper, but to verify it actually works... you need hardware, and someone that cares about nixos+5.15+rtl cards! |
|
If you don't have any real users to rely on, than we can also disable those drivers for newer kernel versions and wait until someone can try one of the forks. |
Random comment/response: I did this a few years ago with some ARM boards and software-defined radios, using Hydra for orchestration. It was glorious! |
|
the force is strong with you @tomberek , this needs to happen again, and become glorious once more! :-) 'Nixos Certified Hardware' 🥇 🥇 |
|
Thankfully, I've been testing my Intel wireless card by using the NixOS Hardware Certification test suite. Looks like it passed on 5.14.15.
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-iso-unable-to-boot-in-uefi-mode-but-other-distros-can/16473/6 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Co-authored-by: nixinator 33lockdown33@protonmail.com
ZHF: #144627
@jonringer, @tomberek , @nrdxp
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)