Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove unused args #145804

Merged
merged 1 commit into from Nov 13, 2021
Merged

treewide: remove unused args #145804

merged 1 commit into from Nov 13, 2021

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Nov 13, 2021

Motivation for this change

The misc subtree had a few derivations with unused arguments in the derivation inputs.
The cleanup was done manually with a bit of ad-hoc scripting.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title pkgs.misc: remove unused args treewide: remove unused args Nov 13, 2021
@Mic92 Mic92 merged commit 7e7e16c into NixOS:master Nov 13, 2021
@wamserma
Copy link
Member Author

@Mic92 Thanks for merging, but it is by no means treewide. There's well over thousand .nix files waiting for clean-up.

@wamserma wamserma deleted the arg-cleanup-misc branch November 13, 2021 23:04
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/low-effort-and-high-impact-tasks/21095/48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants