Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddy: build only with go 1.6 #14709

Merged
merged 1 commit into from
Apr 15, 2016
Merged

caddy: build only with go 1.6 #14709

merged 1 commit into from
Apr 15, 2016

Conversation

davidak
Copy link
Member

@davidak davidak commented Apr 14, 2016

Things done

caddys readme suggests:

Note: You will need Go 1.6 or newer.

@angus-g @joachifm

@davidak
Copy link
Member Author

davidak commented Apr 15, 2016

👍 ready to merge

@angus-g
Copy link
Contributor

angus-g commented Apr 15, 2016

Looks good to me. Just wondering if it should be disabled = isGo14 || isGo15 to be in-line with the way terraform does it. (Probably a minor point)

@davidak
Copy link
Member Author

davidak commented Apr 15, 2016

@angus-g net_go14 does it this way. maybe we don't need that line at all because the version is set by go16Packages, but it's more safe that it newer get's build with an incompatible version. your suggested way would support go1.7 and up, so i changed it. thanks!

@joachifm joachifm merged commit dfc6d42 into NixOS:master Apr 15, 2016
@davidak davidak deleted the caddy-go16 branch April 16, 2016 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants