Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xxh: init at 0.8.8 #147189

Merged
merged 6 commits into from Jan 28, 2022
Merged

xxh: init at 0.8.8 #147189

merged 6 commits into from Jan 28, 2022

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Nov 23, 2021 •
edited

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

legendofmiracles
legendofmiracles reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@legendofmiracles legendofmiracles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting needs more space in my opinion.

pkgs/tools/networking/xxh/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/xxh/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/xxh/default.nix Outdated Show resolved Hide resolved
@pasqui23 @legendofmiracles
xxh:platform set by python
510ef16 
Co-authored-by: legendofmiracles <30902201+legendofmiracles@users.noreply.github.com>
pasqui23 and others added 2 commits November 25, 2021 16:57
@pasqui23 @SuperSandro2000
xxh: formatting
a37d518 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@pasqui23 @legendofmiracles
xxh: better description
6024d6c 
Co-authored-by: legendofmiracles <30902201+legendofmiracles@users.noreply.github.com>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/661

@msm-code
Copy link
Contributor

My shot at helping in review (since I find xxh useful and would love to have it on nixos).

I've built and tested this PR with:

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 147189"

It works correctly on my machine.

Reviewed points
  • [?] package path fits guidelines
  • [?] package name fits guidelines
  • [?] package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • [?] build time only dependencies are declared in nativeBuildInputs
  • [?] source is fetched using the appropriate function
  • [?] phases are respected
  • [?] patches that are remotely available are fetched with fetchpatch

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/426

@legendofmiracles
Copy link
Contributor

legendofmiracles commented Jan 1, 2022 •
edited

In the past days 0.8.8 has been released, I also wrote a patch to update it here + some smaller other changes

@pasqui23 pasqui23 changed the title xxh: init at 0.8.7 xxh: init at 0.8.8 Jan 1, 2022
@pasqui23 pasqui23 mentioned this pull request Jan 1, 2022
Closed
13 tasks
SuperSandro2000
SuperSandro2000 reviewed Jan 17, 2022
View reviewed changes
nixos/tests/xxh.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/xxh/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/436

@SuperSandro2000 SuperSandro2000 merged commit 4690394 into NixOS:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@legendofmiracles legendofmiracles Awaiting requested review from legendofmiracles

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pasqui23 @nixos-discourse @msm-code @legendofmiracles @SuperSandro2000