caddy: include and utilize systemd service from upstream #147305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happysalada
reviewed
Nov 25, 2021
happysalada
reviewed
Nov 25, 2021
happysalada
reviewed
Nov 25, 2021
|
Amazing to have more people interested in caddy ! it's time we give a real chance to the nginx alternative! |
aanderse
force-pushed
the
caddy
branch
2 times, most recently
from
3c4171e
to
1cfa24e
Compare
|
Just finished switching my server to this PR. All good to merge IMO. |
10 tasks
yorickvP
approved these changes
Nov 29, 2021
This was referenced Dec 4, 2021
13 tasks
ncfavier
reviewed
Nov 20, 2022
Comment on lines
-189
to
-190
| AmbientCapabilities = "cap_net_bind_service"; | ||
| CapabilityBoundingSet = "cap_net_bind_service"; |
There was a problem hiding this comment.
Why are those not needed any more?
There was a problem hiding this comment.
Ah, they're in the upstream service file. Never mind me.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I noticed that upstream has moved from a
simpleservice to anotifyservice and we never caught that because we don't use the upstream service. Let's use the upstream unit so we don't miss things like that.Note: Recently I have become interested in
caddyand I'm interested in filing some PRs against ourcaddymodule. I don't usecaddyyet, but I'm looking to start.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes