Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blahtexml: init at 0.9+unstable=20200516 #147594

Merged
merged 1 commit into from Dec 6, 2021

Conversation

xworld21
Copy link
Contributor

Motivation for this change

Add package blahtexml.

Not sure if it works on ARM64, though.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/645

Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 147594 run on x86_64-linux 1

1 package failed to build:
  • blahtexml
blahtexml> Output written on manual.pdf (39 pages, 406493 bytes).
blahtexml> Transcript written on manual.log.
blahtexml> g++ -I. -ISource -ISource/BlahtexCore -ISource/BlahtexXMLin -O2 -c Source/UnicodeConverter.cpp -o bin-blahtex/UnicodeConverter.o
blahtexml> Assembler messages:
blahtexml> Fatal error: can't create bin-blahtex/UnicodeConverter.o: No such file or directory
blahtexml> make: *** [makefile:105: bin-blahtex/UnicodeConverter.o] Error 1

pkgs/tools/typesetting/tex/blahtexml/default.nix Outdated Show resolved Hide resolved
@xworld21
Copy link
Contributor Author

blahtexml> g++ -I. -ISource -ISource/BlahtexCore -ISource/BlahtexXMLin -O2 -c Source/UnicodeConverter.cpp -o bin-blahtex/UnicodeConverter.o
blahtexml> Assembler messages:
blahtexml> Fatal error: can't create bin-blahtex/UnicodeConverter.o: No such file or directory

Lesson: do not enabling parallel building unless absolutely sure. Reverted to default. It should work now.

@Mindavi
Copy link
Contributor

Mindavi commented Nov 28, 2021

It builds fine now for me. It also runs and shows help output (didn't test anything other than that).

pkgs/tools/typesetting/tex/blahtexml/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/blahtexml/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/blahtexml/default.nix Outdated Show resolved Hide resolved
@xworld21
Copy link
Contributor Author

xworld21 commented Dec 5, 2021

I believe it's good now, many thanks for reviewing!

@AndersonTorres AndersonTorres merged commit 04887fa into NixOS:master Dec 6, 2021
@xworld21 xworld21 deleted the blahtexml branch April 3, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants