asusctl: init at 4.0.6 #147786

Cogitri · 2021-11-29T00:26:50Z

Motivation for this change

Add new package asusctl to improve support for ASUS Laptops.

Things done

legendofmiracles

Great work (by the looks of it, can't test it)! I tried my hands at it a while back but gave up very quickly after some complications...

maintainers/maintainer-list.nix

pkgs/tools/misc/asusctl/default.nix

Cogitri · 2021-11-29T01:39:05Z

Hm, for some reason the systemd system unit service isn't copied to share/systemd while the user services are

figsoda · 2021-11-29T03:08:18Z

should probably have more patching since asusctl tries to edit config files (example)

would be nice to have a module as well

pkgs/tools/misc/asusctl/statedir.patch

nixos/modules/services/misc/asusctl.nix

pkgs/tools/misc/asusctl/default.nix

leo60228 · 2021-12-08T16:00:33Z

I could be wrong, but I think the convention is to have separate asusctl: init at 4.0.6 and nixos/asusctl: init commits.

Cogitri · 2021-12-12T10:35:11Z

Fixed 👍

leo60228

I won't be able to test this for a few weeks, but it looks good.

Madouura · 2021-12-16T16:50:22Z

For the most part, it seems to be working fine.
Just a few problems, at least on my configuration.

supergfxd:

sudo systemctl status supergfxd
● supergfxd.service - SUPERGFX
     Loaded: loaded (/etc/systemd/system/supergfxd.service; linked; vendor preset: enabled)
     Active: active (running) since Thu 2021-12-16 10:29:19 CST; 18min ago
   Main PID: 4725 (supergfxd)
         IP: 0B in, 0B out
         IO: 0B read, 20.0K written
      Tasks: 1 (limit: 18444)
     Memory: 284.0K
        CPU: 0
     CGroup: /system.slice/supergfxd.service
             └─4725 /nix/store/ysk35xrh97hb2lrw67h2ndhkk5wzv0mg-supergfxctl-2.0.4/bin/supergfxd

Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: 0000:07:00.4: Function for 0000:07:00.0
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: 0000:07:00.2: Function for 0000:07:00.0
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: 0000:07:00.0: Function for 0000:07:00.0
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: 0000:07:00.5: Function for 0000:07:00.0
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: 0000:07:00.3: Function for 0000:07:00.0
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: 0000:07:00.1: Function for 0000:07:00.0
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: 0000:01:00.0: NVIDIA graphics, setting PM to auto
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: Writing /etc/X11/xorg.conf.d/90-nvidia-primary.conf
Dec 16 10:29:21 tsuki supergfxd[4725]: INFO: GFX: Writing /etc/modprobe.d/supergfxd.conf
Dec 16 10:29:21 tsuki supergfxd[4725]: ERROR: Gfx controller: Command exec error: "modprobe" "nvidia_drm": No such file or directory (os error 2)

asusd:

● asusd.service - ASUS Notebook Control
     Loaded: loaded (/etc/systemd/system/asusd.service; linked; vendor preset: enabled)
     Active: active (running) since Thu 2021-12-16 10:43:10 CST; 4s ago
    Process: 11348 ExecStartPre=/nix/store/fvprxgcxf4px865gdjd81fbwnxcjrg41-coreutils-9.0/bin/sleep 2 (code=exited, status=0/SUCCESS)
   Main PID: 11350 (asusd)
         IP: 0B in, 0B out
         IO: 3.3M read, 12.0K written
      Tasks: 4 (limit: 18444)
     Memory: 2.4M
        CPU: 0
     CGroup: /system.slice/asusd.service
             └─11350 /nix/store/rfdn03vqb8s2kjc5llqi9hmbcrbmnrrn-asusctl-4.0.6/bin/asusd

Dec 16 10:43:10 tsuki asusd[11350]: ERROR: rog_bios_control: Path /sys/firmware/efi/efivars/AsusPostLogoSound-607005d5-3f75-4b2e-98f0-85ba66797a3e: No such fil>
Dec 16 10:43:10 tsuki asusd[11350]: INFO: Battery charge limit: 80
Dec 16 10:43:10 tsuki asusd[11350]: INFO: Device has profile control available
Dec 16 10:43:10 tsuki asusd[11350]: ERROR: AniMe control: Missing functionality: ASUS AniMe device node not found
Dec 16 10:43:10 tsuki asusd[11350]: INFO: Matched to ROG Zephyrus G15 GA503Q
Dec 16 10:43:10 tsuki asusd[11350]: WARN: led_node: Missing functionality: ASUS LED device node not found
Dec 16 10:43:10 tsuki asusd[11350]: WARN: led_node: Missing functionality: ASUS LED device node not found
Dec 16 10:43:10 tsuki asusd[11350]: WARN: led_node: Missing functionality: ASUS LED device node not found
Dec 16 10:43:10 tsuki asusd[11350]: INFO: Using device at: "/dev/hidraw5" for LED control
Dec 16 10:43:10 tsuki systemd[1]: Started ASUS Notebook Control.

supergfx can't seem to modprobe, for some reason.
asusd can't seem to read an efivar, which I have confirmed is there.
asusd won't start without a rebuild, and it goes without mentioning, doesn't start on boot, so I have to nixos-rebuild and then start it manually.

Madouura · 2021-12-18T12:55:58Z

Also, supergfxd creates /etc/supergfxd.conf.
This should be controlled by the nix configuration in nixos/supergfxctl.nix preferably.

Known options:

{
  "gfx_mode": "Hybrid",
  "gfx_managed": true,
  "gfx_vfio_enable": false
}

SuperSandro2000 · 2022-04-27T16:14:36Z

pkgs/tools/misc/supergfxctl/default.nix

+  # Use default phases since the build scripts install systemd services and udev rules too
+  buildPhase = "buildPhase";
+  installPhase = "installPhase";


Suggested change

# Use default phases since the build scripts install systemd services and udev rules too

buildPhase = "buildPhase";

installPhase = "installPhase";

Is that not working?

No, because then cargo build is run instead of make.

We definitely want to run our cargo build phase because it is very different from standard cargo build process. We can run anything else in post phases.
Also we already handle stripping and vendoring outself.

This still needs to be fixed properly

pkgs/top-level/all-packages.nix

mattywillo · 2022-05-14T06:37:53Z

Gave this a quick try, something I noticed: supergfxctrl creates it's own modprobe config at /etc/modprobe.d/supergfxd.conf, pretty unexpected to turn on the service, run supergfxctrl once, then turn off the service and still have the nvidia kernel module blacklisted on next reboot.

Not a showstopper but might throw some people for a loop, not sure the best fix either, since it seems to rely on doing this for any of its features that require a reboot. Ideally the file would be cleaned up if the service is disabled but I don't believe there is a clean way to do that, maybe a patch to prevent it from writing to modprobe.d, and a config option to enable/disable the patch, so the user is aware of non-declarative changes to the system?

Cogitri · 2022-05-24T10:52:49Z

Gave this a quick try, something I noticed: supergfxctrl creates it's own modprobe config at /etc/modprobe.d/supergfxd.conf, pretty unexpected to turn on the service, run supergfxctrl once, then turn off the service and still have the nvidia kernel module blacklisted on next reboot.

Not a showstopper but might throw some people for a loop, not sure the best fix either, since it seems to rely on doing this for any of its features that require a reboot. Ideally the file would be cleaned up if the service is disabled but I don't believe there is a clean way to do that, maybe a patch to prevent it from writing to modprobe.d, and a config option to enable/disable the patch, so the user is aware of non-declarative changes to the system?

I'd rather get this merged first before pouring more work into this PR

mattywillo · 2022-05-25T13:11:18Z

I'd rather get this merged first before pouring more work into this PR

For sure, its a fairly niche situation in an already niche pkg that's only a portion of the PR, with no obviously correct solution, I agree on getting it merged as it is, just wanted to note it down

Madouura · 2022-06-22T22:04:04Z

cc @SuperSandro2000
Could we get this merged please?

Madouura · 2022-06-22T22:04:38Z

Didn't notice the branch conflict.
@Cogitri Could you please fix it?

Cogitri · 2022-06-28T11:21:32Z

Done ✔️

SuperSandro2000 · 2022-06-28T15:36:40Z

pkgs/tools/misc/asusctl/service.patch

+StartLimitInterval=0
+ StartLimitBurst=2
+ Before=multi-user.target
+After=supergfxd.service
+Requires=supergfxd.service
+
+ [Service]
+ Environment=IS_SERVICE=1
+-ExecStartPre=/bin/sleep 2
+ ExecStart=/usr/bin/asusd
+StateDirectory=asusd
+ Restart=on-failure
+ Restart=always
+-RestartSec=1
+RestartSec=4


I'd rather overwrite this within the nixos service than patch it.

SuperSandro2000 · 2022-06-28T15:36:56Z

pkgs/tools/misc/asusctl/default.nix

+  buildPhase = "buildPhase";
+  installPhase = "installPhase";


This also needs a proper solution.

onny · 2022-09-06T12:54:21Z

Please rebase

andOrlando · 2022-09-18T15:37:32Z

Why do we want /etc/supergfxd.conf managed by nix? Would you, in some cases, want ot be able to switch graphics modes on the fly without having to rebuild your system? Also it might be worth updating supergfxctl seeing as it's currently on 4.0.5

devurandom · 2022-09-24T18:00:42Z

It would be great to have some variant of asusctl in NixOS, even if it had some quirks. I would like to at least be able to change from flashing keyboard backlight to a static colour or disable the AniMe Matrix display.

SuperSandro2000 · 2022-09-24T23:32:57Z

Why do we want /etc/supergfxd.conf managed by nix?

Because NixOS tries to be mostly stateless and most system wide settings are managed by it.

Would you, in some cases, want ot be able to switch graphics modes on the fly without having to rebuild your system?

Do we? I don't know but a specialization could fix that.

K900 · 2022-12-02T10:05:25Z

Superseded by #201081

Cogitri force-pushed the asusctl branch from 1f38fad to 170fa4b Compare November 29, 2021 00:45

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 29, 2021

legendofmiracles reviewed Nov 29, 2021

View reviewed changes

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/asusctl/default.nix Show resolved Hide resolved

Cogitri force-pushed the asusctl branch from 170fa4b to 0a8cf4f Compare November 29, 2021 01:24

Cogitri force-pushed the asusctl branch from 0a8cf4f to 5ef2369 Compare November 29, 2021 11:07

github-actions bot added 6.topic: nixos 8.has: module (update) labels Nov 29, 2021

Cogitri force-pushed the asusctl branch from 5ef2369 to 2ffbbeb Compare November 29, 2021 11:09

ofborg bot removed the 10.rebuild-linux: 1 label Nov 29, 2021

Cogitri force-pushed the asusctl branch 2 times, most recently from d34e113 to 42cce08 Compare November 30, 2021 13:01

ofborg bot removed the 10.rebuild-darwin: 1 label Nov 30, 2021

pasqui23 reviewed Nov 30, 2021

View reviewed changes

pkgs/tools/misc/asusctl/statedir.patch Outdated Show resolved Hide resolved

Cogitri force-pushed the asusctl branch from e70022e to 755e241 Compare November 30, 2021 15:09

leo60228 reviewed Dec 4, 2021

View reviewed changes

nixos/modules/services/misc/asusctl.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/asusctl/default.nix Outdated Show resolved Hide resolved

Cogitri force-pushed the asusctl branch from 755e241 to bbec16b Compare December 5, 2021 20:37

Cogitri force-pushed the asusctl branch from bbec16b to 5735913 Compare December 12, 2021 10:35

Cogitri force-pushed the asusctl branch from 5735913 to 1ba01d8 Compare December 12, 2021 10:36

leo60228 approved these changes Dec 14, 2021

View reviewed changes

SuperSandro2000 reviewed Apr 27, 2022

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

SuperSandro2000 added the 2.status: merge conflict label Apr 28, 2022

Cogitri force-pushed the asusctl branch from ec966a4 to 589b192 Compare May 21, 2022 08:49

ofborg bot removed the 2.status: merge conflict label May 21, 2022

bobby285271 removed the 12.approvals: 2 label Jun 10, 2022

SuperSandro2000 added the 2.status: merge conflict label Jun 23, 2022

Cogitri added 3 commits June 28, 2022 11:24

supergfxctl: init at 2.0.5

373110e

nixos/supergfxd: init

e18e06c

asusctl: init at 4.0.7

aeb9365

Cogitri force-pushed the asusctl branch from 589b192 to cf6835b Compare June 28, 2022 09:27

ofborg bot removed the 2.status: merge conflict label Jun 28, 2022

nixos/asusd: init

af905ed

Cogitri force-pushed the asusctl branch from cf6835b to af905ed Compare June 28, 2022 09:34

SuperSandro2000 reviewed Jun 28, 2022

View reviewed changes

K900 mentioned this pull request Nov 24, 2022

asusctl, supergfxctl: init, add nixos modules #201081

Merged

11 tasks

K900 closed this Dec 2, 2022

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

asusctl: init at 4.0.6 #147786

asusctl: init at 4.0.6 #147786

Cogitri commented Nov 29, 2021

legendofmiracles left a comment •

edited

Cogitri commented Nov 29, 2021

figsoda commented Nov 29, 2021

leo60228 commented Dec 8, 2021

Cogitri commented Dec 12, 2021

leo60228 left a comment

Madouura commented Dec 16, 2021

Madouura commented Dec 18, 2021 •

edited

SuperSandro2000 Apr 27, 2022

Cogitri Apr 27, 2022

SuperSandro2000 Apr 28, 2022 •

edited

SuperSandro2000 Jun 28, 2022

mattywillo commented May 14, 2022 •

edited

Cogitri commented May 24, 2022

mattywillo commented May 25, 2022 •

edited

Madouura commented Jun 22, 2022

Madouura commented Jun 22, 2022

Cogitri commented Jun 28, 2022

SuperSandro2000 Jun 28, 2022

SuperSandro2000 Jun 28, 2022

onny commented Sep 6, 2022

andOrlando commented Sep 18, 2022 •

edited

devurandom commented Sep 24, 2022 •

edited

SuperSandro2000 commented Sep 24, 2022

K900 commented Dec 2, 2022

	# Use default phases since the build scripts install systemd services and udev rules too
	buildPhase = "buildPhase";
	installPhase = "installPhase";

asusctl: init at 4.0.6 #147786

asusctl: init at 4.0.6 #147786

Conversation

Cogitri commented Nov 29, 2021

Motivation for this change

Things done

legendofmiracles left a comment • edited

Choose a reason for hiding this comment

Cogitri commented Nov 29, 2021

figsoda commented Nov 29, 2021

leo60228 commented Dec 8, 2021

Cogitri commented Dec 12, 2021

leo60228 left a comment

Choose a reason for hiding this comment

Madouura commented Dec 16, 2021

Madouura commented Dec 18, 2021 • edited

SuperSandro2000 Apr 27, 2022

Choose a reason for hiding this comment

Cogitri Apr 27, 2022

Choose a reason for hiding this comment

SuperSandro2000 Apr 28, 2022 • edited

Choose a reason for hiding this comment

SuperSandro2000 Jun 28, 2022

Choose a reason for hiding this comment

mattywillo commented May 14, 2022 • edited

Cogitri commented May 24, 2022

mattywillo commented May 25, 2022 • edited

Madouura commented Jun 22, 2022

Madouura commented Jun 22, 2022

Cogitri commented Jun 28, 2022

SuperSandro2000 Jun 28, 2022

Choose a reason for hiding this comment

SuperSandro2000 Jun 28, 2022

Choose a reason for hiding this comment

onny commented Sep 6, 2022

andOrlando commented Sep 18, 2022 • edited

devurandom commented Sep 24, 2022 • edited

SuperSandro2000 commented Sep 24, 2022

K900 commented Dec 2, 2022

legendofmiracles left a comment •

edited

Madouura commented Dec 18, 2021 •

edited

SuperSandro2000 Apr 28, 2022 •

edited

mattywillo commented May 14, 2022 •

edited

mattywillo commented May 25, 2022 •

edited

andOrlando commented Sep 18, 2022 •

edited

devurandom commented Sep 24, 2022 •

edited