Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prisma: 3.5.0 -> 3.6.0 #148028

Merged
merged 1 commit into from Dec 17, 2021
Merged

prisma: 3.5.0 -> 3.6.0 #148028

merged 1 commit into from Dec 17, 2021

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Nov 30, 2021

Motivation for this change

3.6.0 is out https://github.com/prisma/prisma/releases/tag/3.6.0

What I did in this PR is taking the version for nodePackages.prisma from prisma-engines. You cannot update the node package without the engines, so they should always match versions.

The @prisma/engines dependency is for the download logic, we skip it completely with nix, so we don't really need to update it with every release.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/660

@bobby285271 bobby285271 merged commit 10cd1a0 into NixOS:master Dec 17, 2021
@pimeys pimeys deleted the prisma-3.6.0 branch December 17, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants