xmonad_0_17_0: add @ento's updated xmonad nix compatibility patch #148135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/haskell-modules/patches/xmonad-nix.patch updated for 0.17.0. It allows xmonad to find GHC (and xmessage), and thus recompile itself.
NickHu
requested review from
cdepillabout,
expipiplus1,
maralorn and
sternenseemann
as code owners
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/use-latest-version-of-xmonad-0-17-0/16191/13 |
|
Cherry-picked as 36d5761. Changed the commit message a bit (using @ mentions in commits always ends up with a lot of spam in busy repos) and did some minor fixups. Thanks! Will land in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This patch is the existing patch for 0.15.0 updated for 0.17.0. It allows xmonad_0_17_0 to find GHC (and xmessage), and thus recompile itself. Without this, the home-manager module doesn't work properly for example.
Thanks to @ento for updating this patch! All credit goes to him:
https://discourse.nixos.org/t/use-latest-version-of-xmonad-0-17-0/16191/5
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes