Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs-17_x: fix darwin build by backporting an upstream patch #149556

Merged
merged 1 commit into from Dec 10, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Dec 8, 2021

Motivation for this change

Fixing up #145865 on Darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bobrik
Copy link
Contributor Author

bobrik commented Dec 8, 2021

Looks like it still doesn't compile on x86_64-darwin, but at least aarch64-darwin works now.

@bobrik
Copy link
Contributor Author

bobrik commented Dec 8, 2021

nodejs/build#2769 seems related to x86_64-darwin issues. Nixpkgs targets macOS 10.12, while nodejs 17 does not guarantee it will work:

[^7]: Our macOS x64 Binaries are compiled with 10.13 as a target.
    However there is no guarantee compiling on 10.13 will work as Xcode11 is
    required to compile.

@marsam marsam merged commit dc91ac8 into NixOS:master Dec 10, 2021
@bobrik bobrik deleted the ivan/nodejs-macos-fix branch December 11, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants