vmware-horizon-client: 2106.1 -> 2111

[buckley310]

Motivation for this change

While updating, I also fixed these things, which were unavailable before:
1, real-time audio/video support (microphone/webcam)
2, allow USB passthrough
3, adds a configText argument which will be presented as the contents of /etc/vmware/config to horizon

A module / systemd service can take care of this in the future, but right now in order to get USB passthrough working, the user must manually run the following commands before launching the horizon client:

sudo mkdir -p "/var/run/vmware/$UID"
sudo chown "$USER" "/var/run/vmware/$UID"
sudo vmware-usbarbitrator

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[buckley310]

Tagging for backport because I actually needed the bugfix for audio/video when my work started using Teams meetings and I'm guessing this is not an uncommon use-case.

[aaronchall]

I like the name change, vmware-horizon-client is much more searchable and recognizable than vmware-view. Thanks for doing this, the sooner I can discard my reliance on Windows for anything, the better.

[aaronchall]

After adding the following nixpkgs.overlays entry to my configuration.nix file:

  nixpkgs.overlays = let
    owner = "buckley310";
    branchname = "vmwareview"; # branchname or rev
    pkgsReview = pkgs.fetchzip {
      url = "https://github.com/${owner}/nixpkgs/archive/${branchname}.tar.gz";
      sha256 = "12xcnbms1rgm720ca5w7gn7dgmf7kx098rkbzcq6ixyz0haabj28";
    };
  in [
    (self: super: {
      review = import pkgsReview { overlays = []; config = super.config; };
      vmware-horizon-client = self.review.vmware-horizon-client;
    })
  ];

and an entry for vmware-horizon-client in my environment.systemPackages, I have tested this change myself on my system and it successfully enables audio input and output - which means I get to give an old Windows computer a new home. Thank you, @buckley310 - I look forward to removing this overlay from my configuration.nix when this pull request is accepted.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/439

[SuperSandro2000]

Please use copyDesktopItems instead.

[github-actions]

Successfully created backport PR #158260 for release-21.11.