Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: use PyPI mirror #15001

Merged
merged 2 commits into from
Apr 26, 2016
Merged

Python: use PyPI mirror #15001

merged 2 commits into from
Apr 26, 2016

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Apr 26, 2016

Recently PyPI changed their url scheme at https://pypi.python.org. After some complaints they mapped the older urls to the new ones again. This is however done on the upcoming PyPI 2.0 website, and not the current website.

In this PR the new website (https://pypi.io) is added as mirror. The new website works most of the time but can still fail occasionally and is not as reliable as the old one.

cc @domenkozar @wkennington

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @bjornfor, @matthiasbeyer and @domenkozar to be potential reviewers

@domenkozar
Copy link
Member

Travis seems to indicate it's a mass rebuild, I don't understand why. It's changing only fixed output drvs.

@dezgeg
Copy link
Contributor

dezgeg commented Apr 26, 2016

Seems like nox is comparing drv paths: https://github.com/madjar/nox/blob/master/nox/nixpkgs_repo.py#L80

@domenkozar
Copy link
Member

Nice catch! Opened madjar/nox#44

@domenkozar
Copy link
Member

I really see no reason to merge this, we'll fix issues as they come or switch to another mirror.

@domenkozar domenkozar merged commit d5e6a44 into NixOS:master Apr 26, 2016
@FRidh FRidh deleted the mirror branch April 26, 2016 12:42
@domenkozar
Copy link
Member

Verified using pythonPackages.msgpack and bumped the version.

@grahamc
Copy link
Member

grahamc commented Apr 26, 2016

My only concern with this is we're now codifying that pypi is the old style pypi URLs. In fact, PyPI has changed their URLs and are only providing these old style redirects as a favor for packagers like us. Given the rest of @FRidh's goals, I think it would be wiser to rename the pypi mirror to pypi-v1 (or whatever) so then we have an easier time moving forward by calling the newer style URLs pypi-v2.

@FRidh
Copy link
Member Author

FRidh commented Apr 26, 2016

If we keep in mind that this is not an official API and agree that if it turns out to be unreliable and that we need a better solution by using say the API, then I think it is fine.

I will anyway work further on autogenerated urls and hashes using the API.

@FRidh
Copy link
Member Author

FRidh commented Apr 26, 2016

with the pypi-v1 you have a good point, at least, thinking about people that use it outside of buildPythonPackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants