Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin.postLinkSignHook: fix reference to codesign_allocate #150074

Closed
wants to merge 1 commit into from

Conversation

Kha
Copy link
Contributor

@Kha Kha commented Dec 10, 2021

Motivation for this change

Make wrapped linkers work outside of stdenv, such as in runCommand.

Fixes #148189

Things done

As this triggers basically a full Darwin rebuild, I did not test more than building and running bash

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

/cc @thefloweringash

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/repairing-codesign-allocate-on-darwin/16326/2

@domenkozar
Copy link
Member

cc @NixOS/darwin-maintainers

@NilsIrl
Copy link
Member

NilsIrl commented Dec 31, 2021

image

Got this while running nixpkgs-review, not sure what to do.

error: cannot coerce null to a string

       at /nix/store/i216g4xbzdf3sglffq28zas4kllfbr9b-nixpkgs-review-2.6.4/lib/python3.9/site-packages/nixpkgs_review/nix/evalAttrs.nix:12:35:

           11|     pkg = lib.attrByPath attrPath null pkgs;
           12|     maybePath = builtins.tryEval "${pkg}";
             |                                   ^
           13|   in rec {
nix --experimental-features nix-command --system aarch64-darwin eval --json --impure --expr (import /nix/store/i216g4xbzdf3sglffq28zas4kllfbr9b-nixpkgs-review-2.6.4/lib/python3.9/site-packages/nixpkgs_review/nix/evalAttrs.nix { allowAliases = true; attr-json = /var/folders/np/f2vk_vjj4257l5xsg39fs2t00000gn/T/tmpke49_t33; }) failed to run, /var/folders/np/f2vk_vjj4257l5xsg39fs2t00000gn/T/tmpke49_t33 was stored inspection
https://github.com/NixOS/nixpkgs/pull/150074 failed to build
$ git worktree prune

@sternenseemann
Copy link
Member

PR'd an evaluating, but otherwise untested version of this at #148282

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/repairing-codesign-allocate-on-darwin/16326/6

@Kha
Copy link
Contributor Author

Kha commented Jan 6, 2022

Closing in favor of #148282

@Kha Kha closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants