team-list: add bazel team #150529
Merged
team-list: add bazel team #150529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok |
|
ok 👍 |
|
ok 👍 |
|
ok |
|
|
|
ok |
|
Okay, I added everybody who said ok so far in an extra commit. @marsam @olebedev @groodt I invited you to the @NixOS/bazel team as well. @timothyklim I noticed that you didn’t yet have an entry in https://github.com/NixOS/nixpkgs//blob/master/maintainers/maintainer-list.nix so if you want to add yourself there, I can add you to the team-list.nix |
|
ok 👍 |
|
I vote for adding @aherrmann as well. |
|
ok |
Profpatsch
force-pushed
the
maintainers-bazel-team
branch
from
4153c90
to
bae19ee
Compare
|
Updated & invited. |
13 tasks
(refactor) We are going to set up a maintenance team for bazel & tools.
According to the answers in NixOS#150529
Profpatsch
force-pushed
the
maintainers-bazel-team
branch
from
bae19ee
to
abfd528
Compare
|
@ylecornec I added you as well & rebased on master. I’d merge late today or tomorrow, additional maintainers can be added later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(refactor)
We are going to set up a maintenance team for bazel & tools.
@kalbasit @avdv @ethercrow @uri-canva I invited you to the @NixOS/bazel group, if you want to join the maintenance team, this will give people the ability to ping the whole team. I am unable to add non-members of Nixos though.
This PR sets up a team within nixpkgs, so that the maintainer field in all bazel packages can mention that team (plus some extra maintainers via list concatenation). I only added @mboes to that list for now, since he is in the current maintainer lists.
I would add a bunch more people, please can you comment with
okif you want to be in the maintainer list, then I’d add you in this PR (you can always add or remove yourself later ofc).