Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: rephrase definition for indented strings #15086

Merged
merged 1 commit into from
Apr 30, 2016
Merged

Manual: rephrase definition for indented strings #15086

merged 1 commit into from
Apr 30, 2016

Conversation

NotaseCretagen
Copy link
Contributor

@NotaseCretagen NotaseCretagen commented Apr 29, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Did not test this in any way... please suggest a way to test(the manual?), if needed and/or for the future.

Text stolen from: https://nixos.org/nix/manual/#ssec-values

Closes #15076

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vcunat and @aneeshusa to be potential reviewers

@domenkozar domenkozar merged commit e704c90 into NixOS:master Apr 30, 2016
@Profpatsch
Copy link
Member

Nope, breaks the manual.

@Profpatsch
Copy link
Member

Did not test this in any way... please suggest a way to test(the manual?), if needed and/or for the future.

Did you read the README in docs? nixos/doc/manual/README

@NotaseCretagen
Copy link
Contributor Author

@Profpatsch I didn't... brb

@NotaseCretagen
Copy link
Contributor Author

#15102

@NotaseCretagen
Copy link
Contributor Author

NotaseCretagen commented Apr 30, 2016

yup, I get the same error...

$ time nix-build /etc/nixos/nixpkgs/nixos/release.nix -A manual.x86_64-linux
these derivations will be built:
/nix/store/zwphwyd8d0c3cqxpwrfdqnyqks2fb0rk-options-db.xml.drv
/nix/store/0s2q1sb94g96vi70ymf604610h2hxg7a-nixos-manual.drv
building path(s) ‘/nix/store/ksjryp29yplcq2p70xl02c4sjx7azzkh-options-db.xml’
building path(s) ‘/nix/store/vrs541a2n0dgwsy4q3wm201m4rki18m7-nixos-manual’
manual.xml:9: element partintro: Relax-NG validity error : Did not expect element partintro there
manual.xml:9: element para: Relax-NG validity error : Did not expect element para there
manual.xml:5: element section: Relax-NG validity error : Did not expect element section there
manual.xml:5: element section: Relax-NG validity error : Element chapter has extra content: section
manual.xml:5: element part: Relax-NG validity error : Element part failed to validate content
manual.xml fails to validate
builder for ‘/nix/store/0s2q1sb94g96vi70ymf604610h2hxg7a-nixos-manual.drv’ failed with exit code 3
error: build of ‘/nix/store/0s2q1sb94g96vi70ymf604610h2hxg7a-nixos-manual.drv’ failed

@Profpatsch
Copy link
Member

@NotaseCretagen Take a look at your changes, try to find out what they do differently than the parts around them. ;)

@NotaseCretagen
Copy link
Contributor Author

NotaseCretagen commented Apr 30, 2016

Shouldn't have this have detected it, btw: https://travis-ci.org/NixOS/nixpkgs/builds/126729080
(I mean, for future reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual: misleading description for '' multi-line quotes
5 participants