Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Napari #151265

Merged
merged 9 commits into from Jan 1, 2022
Merged

Napari #151265

merged 9 commits into from Jan 1, 2022

Conversation

SomeoneSerge
Copy link
Contributor

Motivation for this change

Adds napari, a scientific image viewer.
Please note, it's my first PR to nixpkgs, I may not be aware of some rules or conventions

Things done
  • Dependencies also packaged in separate commits but in the same PR - should they be merged separately?
    • One of the dependencies - cachey - is part of dask suite; should I add @FRidh to maintainers, as in other dask packages?
    • qt-related packages (like superqt, magicgui) segfault during tests, although the final app works
  • I also don't know if some special steps need to be taken in regards to nixpkgs-update integration, cc @ryantm
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/672

@SomeoneSerge SomeoneSerge changed the title WIP: Napari Napari Dec 31, 2021
@ryantm
Copy link
Member

ryantm commented Jan 1, 2022

@SomeoneSerge I quickly looked over your changes and I think automated updates from r-ryantm/nixpkgs-update should work with them.

@symphorien symphorien merged commit 4838bb1 into NixOS:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SomeoneSerge @nixos-discourse @ryantm @symphorien