Allow any hash function for some git-based fetch* derivations #15139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to use overrideDerivation (like fetchzip utilizes fetchurl) and thus support any hash that's supported by the underlying fetchurl? |
Instead of hard-coding which hash types are available, merge the input arg set into the fetchzip arguments to enable passing any hash type that the underyling fetchurl (underneath fetchzip, which does the same thing) supports for hash agility. Also, provide rev attributes on all of these derivations, not just fetchFromGitHub.
aneeshusa
force-pushed
the
allow-sha512-for-various-fetch-derivations
branch
from
57f7821
to
208f1fb
Compare
|
@groxxda That's a good suggestion! I didn't need to use I also gave all 5 of these derivations the |
aneeshusa
changed the title
This was referenced Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)This didn't cause a mass-rebuild for me. I also tested using sha512 in the tmux derivation which uses fetchFromGitHub, which worked fine.