Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfizz: 0.5.1 -> 1.1.1 #152092

Merged
merged 1 commit into from Dec 29, 2021
Merged

sfizz: 0.5.1 -> 1.1.1 #152092

merged 1 commit into from Dec 29, 2021

Conversation

hirenashah
Copy link
Contributor

@hirenashah hirenashah commented Dec 25, 2021

Motivation for this change

v1.1.1 is available, but the package has not been updated since v0.5.1.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@magnetophon
Copy link
Member

magnetophon commented Dec 25, 2021

I've also ried to update, but ran into sfztools/sfizz#505 (comment).
This PR has the same issue: when zenity is not in the path, the plugin isn't able to call it, even with the patching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants