New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.dm-tree: refactor to build from sources #152971
Conversation
-set(ABSEIL_VER 20210324.2) | ||
-include(ExternalProject) | ||
-ExternalProject_Add(abseil-cpp | ||
- GIT_REPOSITORY https://github.com/abseil/abseil-cpp.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of vendored source is an anti-pattern. Would be nice if upstream supported find_package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker for this PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased to the most recent commit and changed the patch to hopefully be submittable to the upstream (= falling back to vendored deps if find_package
fails), will try to open PR with them but keeping the patch here for now as I want to decouple upstream PR from this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after comments are addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I'll squash and merge tomorrow unless anyone objects.
tensorflow-probability 0.8 was broken and marked as such (in NixOS#108977) because of a dependency on dm-tree, which seems not to have been available. Since dm-tree is now available in nixpkgs (NixOS#152971), tensorflow-probability is easy to fix and to upgrade.
tensorflow-probability 0.8 was broken and marked as such (in NixOS#108977) because of a dependency on dm-tree, which seems not to have been available. Since dm-tree is now available in nixpkgs (NixOS#152971), tensorflow-probability is easy to fix and to upgrade.
Motivation for this change
Part of "extra JAX libraries / frameworks" implementation, see the discussion in #152754
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes