Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agdaPackages.generics: Init at 1.0.1 #153757

Merged
merged 1 commit into from
Jul 1, 2024
Merged

agdaPackages.generics: Init at 1.0.1 #153757

merged 1 commit into from
Jul 1, 2024

Conversation

turion
Copy link
Contributor

@turion turion commented Jan 6, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@turion turion mentioned this pull request Jan 6, 2022
Closed
@turion
Copy link
Contributor Author

turion commented Jan 6, 2022

CC @alexarice @neosimsim

@turion
Copy link
Contributor Author

turion commented Jan 6, 2022 •
edited
Loading

@ofborg build agdaPackages.generics

@turion
Copy link
Contributor Author

turion commented Jan 6, 2022

The build failures for Agda are well known: #149692

@turion turion force-pushed the dev_add_agda_generics branch 2 times, most recently from 2f72307 to 5ce02e8 Compare January 13, 2022 11:46
This was referenced Jan 14, 2022
Closed
Closed
@turion
Copy link
Contributor Author

turion commented Jan 14, 2022

Stuck on flupe/generics#7

@turion turion changed the title agdaPackages.generics: Init at rc agdaPackages.generics: Init at 1.0.0 May 6, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 12, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@turion
Copy link
Contributor Author

turion commented Jul 1, 2024 •
edited
Loading

@ofborg build agdaPackages.generics

@turion turion mentioned this pull request Jul 1, 2024
Closed
@turion
Copy link
Contributor Author

turion commented Jul 1, 2024

@ofborg build agdaPackages.generics

@turion
Copy link
Contributor Author

turion commented Jul 1, 2024

The maintainer very helpfully supplied an updated version for standard library 2.0 😄 flupe/generics#11

@turion turion changed the title agdaPackages.generics: Init at 1.0.0 agdaPackages.generics: Init at 1.0.1 Jul 1, 2024
@turion turion merged commit a28173c into NixOS:master Jul 1, 2024
13 of 15 checks passed
@turion turion deleted the dev_add_agda_generics branch July 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice left review comments

Assignees
No one assigned
Labels
6.topic: agda 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turion @alexarice @wegank