Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: enable FF for many gamepads #155613

Merged
merged 1 commit into from Feb 16, 2022
Merged

linux: enable FF for many gamepads #155613

merged 1 commit into from Feb 16, 2022

Conversation

SuperSamus
Copy link
Contributor

Motivation for this change

Enable force feedback (also known as rumble) to improve gaming experience for the game devices it wasn't set on (according to /proc/config.gz).
This PR enables FF for:

  • HID_GREENASIA
  • JOYSTICK_PSXPAD_SPI
  • HID_LOGITECH (Flight System G940, the other FFs were already enabled)
  • HID_NINTENDO
  • HID_PLAYSTATION

All of these are already enabled on Fedora and Arch Linux (the ones I checked).
Supersedes #155387.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

linuxKernel.kernels: ...

I don't think that attrpath exists. I'd write "linux:" in the commit message.

@SuperSamus SuperSamus changed the title linuxKernel.kernels: enable FF for many gamepads linux: enable FF for many gamepads Jan 24, 2022
Madouura
Madouura approved these changes Jan 30, 2022
View reviewed changes
Copy link
Contributor

@Madouura Madouura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl changed the base branch from master to staging February 2, 2022 05:29
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/728

@SuperSandro2000 SuperSandro2000 merged commit f61999e into NixOS:staging Feb 16, 2022
vcunat added a commit that referenced this pull request Feb 24, 2022
@vcunat
linux: restrict option JOYSTICK_PSXPAD_SPI_FF
f57be3c 
This broke older kernels in PR #155613 (commit 8aae7af).
I only checked the kernel versions that we maintain,
so (>= 4.14) might be an imprecise condition.
@SuperSamus SuperSamus deleted the hid_ff branch April 21, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madouura Madouura Madouura approved these changes

Assignees
No one assigned
Labels
6.topic: kernel 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SuperSamus @bjornfor @nixos-discourse @Madouura @SuperSandro2000