Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canon-cups-ufr2: 3.70 -> 5.40 #155685

Merged
merged 1 commit into from
Jan 20, 2022
Merged

canon-cups-ufr2: 3.70 -> 5.40 #155685

merged 1 commit into from
Jan 20, 2022

Conversation

dmayle
Copy link
Contributor

@dmayle dmayle commented Jan 19, 2022

Motivation for this change

The current version of the canon driver doesn't have support for many new printers (notably, in my case, the imageClass MF743CDW). This matches issue #155683

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Fixes: #155683
Closes: #79689

@veprbl
Copy link
Member

veprbl commented Jan 19, 2022

With this, we can close #79689, right?

@dmayle
Copy link
Contributor Author

dmayle commented Jan 19, 2022

@veprbl most likely, yes. There are a large number of printers supported with these drivers, and I've only tested with the one I have access to, which did not require the the preload patching done for 3.70 (nor the updated patching performed in #79689 ), but there's always a chance that there is a printer which might need it.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@veprbl
Copy link
Member

veprbl commented Jan 20, 2022

Result of nixpkgs-review pr 155685 run on x86_64-linux 1

1 package built:
  • canon-cups-ufr2

@kylesferrazza
Copy link
Member

I no longer have a Canon printer for testing -- can you add a commit to this PR removing me from the maintainers list?

Thanks!

@veprbl veprbl merged commit b4797ea into NixOS:master Jan 20, 2022
@kylesferrazza
Copy link
Member

I'll open a new PR :)

@dmayle dmayle deleted the update-canon-ufr2 branch January 20, 2022 17:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cant-print-on-a-canon-mf3010/42794/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update canon-cups-ufr2 to a more recent version (5.4.0) which supports modern printers
5 participants