Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/redis: fix port option #156004

Merged
merged 1 commit into from Jan 22, 2022
Merged

nixos/redis: fix port option #156004

merged 1 commit into from Jan 22, 2022

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Jan 21, 2022

Motivation for this change

#142635 (comment)

Things done
  • Enable TCP by default only when the redis-server has no name.
  • Do not disable TCP when bind is null.
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Ping @lunik1.

@Ma27
Copy link
Member

Ma27 commented Jan 21, 2022

Please check the eval-error, it seems to be related to your changes.

nixos/modules/services/databases/redis.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/redis.nix Outdated Show resolved Hide resolved
@ju1m
Copy link
Contributor Author

ju1m commented Jan 21, 2022

Sorry for the brain-dead typo (evolving in a degraded work environment for a few months..)

@ncfavier
Copy link
Member

The defaultTexts need literalExpression otherwise they will be rendered as strings. See line 60 for example.

@ju1m
Copy link
Contributor Author

ju1m commented Jan 21, 2022

@ncfavier, oh sorry, so it was not only a brain-dead typo, but also a semantic change that was not obvious to me.

@ncfavier ncfavier requested a review from Ma27 January 21, 2022 22:04
@symphorien
Copy link
Member

@GrahamcOfBorg test redis

@symphorien symphorien merged commit cb19ae8 into NixOS:master Jan 22, 2022
@ju1m ju1m deleted the redis branch January 23, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants