Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got: 0.64 -> 0.66 #156351

Merged
merged 1 commit into from
Jan 31, 2022
Merged

got: 0.64 -> 0.66 #156351

merged 1 commit into from
Jan 31, 2022

Conversation

heph2
Copy link
Contributor

@heph2 heph2 commented Jan 23, 2022

Motivation for this change

Update to 0.66

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like one of the dependencies (libmd) is not supported on x86_64-darwin, so maybe this package should change platforms to exclude x86_64-darwin? Can be a follow-up PR.

error: Package ‘libmd-1.0.4’ in /Users/gordias/Documents/Code/nixpkgs/pkgs/development/libraries/libmd/default.nix:18 is not supported on ‘x86_64-darwin’, refusing to evaluate.

Otherwise, LGTM (but was unable to build/test on my machine)

Copy link
Contributor

@wahjava wahjava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to build, and work fine. Thanks!

@heph2
Copy link
Contributor Author

heph2 commented Jan 24, 2022

@NotGordias So should i make another PR that change the supported platforms?

@ghost
Copy link

ghost commented Jan 25, 2022

@heph2 I don't have a strong preference and didn't want to block this PR. I think either way is fine!

@bobby285271 bobby285271 merged commit 5860e2d into NixOS:master Jan 31, 2022
@ghost ghost mentioned this pull request Jan 31, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants