Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fail2ban: add option to enable sending mail #157364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhilippWoelfel
Copy link
Contributor

Motivation for this change

Addresses #156480 (cannot send mail because the systemd unit is sandboxed). This PR adds the option fail2ban.mail.enable. Setting this prevents adding NoNewPrivileges and ProtectSystem in the systemd unit configuration. It also adds mta=mail to jail.conf.local, and adds the package mailutils.

This PR also adds options fail2ban.mail.destemail and fail2ban.mail.sender that add the corresponding entries to jail.conf.local.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@PhilippWoelfel PhilippWoelfel marked this pull request as ready for review January 30, 2022 08:14
@dasJ dasJ changed the title fail2ban: add option to enable sending mail nixos/fail2ban: add option to enable sending mail Jan 30, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 30, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants