gamehub: init at 0.16.3-2

[pasqui23]

Motivation for this change

Fixes #58189

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[pasqui23]

Wait as soon as I try to open the screen with all the aviable games it goes segmentation fault ☹

[pasqui23]

It also freeze if I try to setup itch account even through I have it installed

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/50

[bbigras]

Is the https://tkashkin.tk/projects/gamehub/ URL good? It's "blocked" by ublock origin on my side.

[pasqui23]

Here is what I'm getting from running it

; result/bin/gamehub 
def-matcher: command not found
Gtk-Message: 16:29:25.829: Failed to load module "appmenu-gtk-module"
[INFO]   - GameHub
[INFO]       Version: 0.16.1--
[INFO]       Branch:
[INFO]   - Environment
[INFO]       Distro:  NAME=NixOS
[INFO]       DE:      KDE
[INFO]       GTK:     3.24.31
[INFO]       Themes:  Breeze | Tela-black-dark
[FATAL]  [Json] json_object_get_object_member: assertion 'node != NULL' failed
[FATAL]  [Json] json_object_get_string_member: assertion 'object != NULL' failed
zsh: segmentation fault (core dumped)  result/bin/gamehub

[pasqui23]

Here is the core dump:
https://e1.pcloud.link/publink/show?code=XZjCbpZjM2kWKiP6MFWvJI3WD6DBBtt9dw7

[AndersonTorres]

whitespace

Suggested change

[pasqui23]

This is ready, my problems are all related to broken steam

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/827

[gador]

Hi, thanks for your PR!
A couple of points:

• please address the failing tests
• please address the requested changes from @AndersonTorres
• please fill out the PR template and check the points

[rapenne-s]

Result of nixpkgs-review pr 158044 run on x86_64-linux 1

1 package built:

• gamehub

[rapenne-s]

While the program runs fine, it doesn't keep the credentials for the various services (dunno if voluntary or an upstream bug). I tried to install a game from GOG but it fails, hereis the error for a Linux game.

Verifying archive integrity... All good.
Uncompressing Darwinia (GOG.com)  100%  
Collecting info for this system...
Operating system: linux
CPU Arch: x86_64
trying mojosetup in bin/linux/x86_64
USING 
./startmojo.sh: ligne 55: /tmp/selfgz304947047/bin/linux/x86_64/mojosetup: No such file or directory
Error: Couldn't run mojosetup
/home/jeux/Games/_Collection/GOG/Darwinia - 10000th Anniversary Edition/darwinia_2_2_0_169_g706f93f4_gnu_linux_full_55550.sh: ligne 517: /bin/rm: No such file or directory

[pasqui23]

@rapenne-s Weird, It did kept the credentials for GOG.

In fact I would consider it ready, the problems with steam were a mistake in my configuration.nix

[MalteT]

Result of nixpkgs-review pr 158044 run on x86_64-linux 1

1 package failed to build:

• gamehub

[MalteT]

Here's the build log, might be something on my part, I'm not sure: https://gist.github.com/MalteT/30adc398eaefb603e98a0b7a88720ecc

[pasqui23]

Weird, on my machine it builds???

[rapenne-s]

Result of nixpkgs-review pr 158044 run on x86_64-linux 1

1 package failed to build:

• gamehub

error: builder for '/nix/store/n64ycpb3z61miivcb8xd8bp53zlqwinr-GameHub-0.16.1-2.drv' failed with exit code 1;
       last 10 log lines:
       >   197 |                       public Style?  style     { get; protected construct set; default = null; }
       >       |                                                     ^~~~~~~~~~~~~~~~~~~~~~~~
       > ../src/data/compat/WineWrap.vala:115.53-115.86: warning: Access to possible `null'. Perform a check or use an unsafe cast.
       >   115 |                           cmd = { "bash", "-c", "./*_wine.sh -dirname=" + (runnable as GOGGame).escaped_name };
       >       |                                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > ../src/utils/Utils.vala:723.20-723.35: note: Assignment: Unsafe conversion from `int' to `GameHub.Utils.Logger.ConsoleColor'
       >   723 |                       if(!foreground) color_code += 10;
       >       |                                      ^~~~~~~~~~~~~~~~
       > Compilation failed: 1 error(s), 54 warning(s)
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/n64ycpb3z61miivcb8xd8bp53zlqwinr-GameHub-0.16.1-2.drv'.
error: 1 dependencies of derivation '/nix/store/f4dxqxy6463jlc9hhbyjxiffvwn0jyk7-review-shell.drv' failed to build

[pasqui23]

K why nix build .#gamehub succeeds while nixpkgs-review fails?

[rapenne-s]

K why nix build .#gamehub succeeds while nixpkgs-review fails?

do you have the exact same branch as the one available on GitHub? No local change? I'll try without nixpkgs-review just to be sure

[rapenne-s]

There must be an issue with nixpkgs-review here. Getting the branch with gh pr checkout 158044 and building gamehub with nix-build -A gamehub or nix build .#gamehub both pass compilation.

[rapenne-s]

There is a 0.16.3-2-master release for gamehub on https://github.com/tkashkin/GameHub/releases which says it fixes building with newer Vala.

I figured out why nixpkgs-review was behaving differently. By default, it rebases the branch on top of master, so it's compiling using latest version of all build inputs. Newer vala got merged in between. More information at https://github.com/Mic92/nixpkgs-review#checkout-strategy-recommend-for-r-ryantm--cachix

Using the command nixpkgs-review pr --checkout commit 158044 to build gamehub using the inputs from its branch version gives a success.

[MalteT]

Can confirm, builds after gh pr checkout 158044. nixpkgs-review pr --checkout commit 158044 works aswell, so this should be fine then?

[SuperSandro2000]

@ofborg build gamehub

[SuperSandro2000]

There must be an issue with nixpkgs-review here.

No, the reason behind it is that both nixpkgs-review and ofborg merge the PR into master before and there the build is broken.

[rapenne-s]

There must be an issue with nixpkgs-review here.

No, the reason behind it is that both nixpkgs-review and ofborg merge the PR into master before and there the build is broken.

this is what I figured out later in the thread. There is also a new gamehub release that's supposed to fix the build.

[pasqui23]

Ok updated it to the latest. lat's merge this before and not nixpkgs-review pr succeeds.

Let's merge this before it breaks again

[rapenne-s]

Result of nixpkgs-review pr 158044 run on x86_64-linux 1

1 package built:

• gamehub

[rapenne-s]

@pasqui23 how do you log into only one service (like GOG) and then use gamehub? When I log in with GOG and click on "ignore" button on the top right corner, I can see my GOG library, but when I restart gamehub I need to login again. Unsure if it's my doing wrong or a bug in gamehub

[MalteT]

@rapenne-s it seems to work for me, I just have to click 'Skip' after every start. But I'm not logged out when restarting gamehub

[AndersonTorres]

Looks fine to me.

[SuperSandro2000]

@ofborg build gamehub