Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/retroarch: add RetroArch as a desktop session #158178

Merged
merged 1 commit into from Feb 10, 2022
Merged

nixos/retroarch: add RetroArch as a desktop session #158178

merged 1 commit into from Feb 10, 2022

Conversation

j0hax
Copy link
Member

@j0hax j0hax commented Feb 4, 2022

Motivation for this change

Similar to kodi, this module allows users to launch a fullscreen RetroArch instance as the desktop.

Example
{
  # somewhere inside configuration.nix
  services.xserver.desktopManager.retroarch = {
    enable = true;
    package = pkgs.retroarchFull;
  };
}
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/716

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as a maintainer. Should we add a test for this?

@j0hax
Copy link
Member Author

j0hax commented Feb 8, 2022

I doubt a test is necessary for such a simple module, but I decided it doesn't hurt to have one anyways 😉

$ nix-build . -A nixosTests.retroarch
/nix/store/pg0i20h1g2xqxz9gpabp7kciwncf5idn-vm-test-run-retroarch

@SuperSandro2000 SuperSandro2000 merged commit 6a4dea5 into NixOS:master Feb 10, 2022
@j0hax j0hax deleted the retroarch-wm branch March 16, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants