Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] wip: gst_all_1.*: fix builds #158280

Merged
merged 6 commits into from Feb 10, 2022
Merged

[staging-next] wip: gst_all_1.*: fix builds #158280

merged 6 commits into from Feb 10, 2022

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 5, 2022 •
edited

Motivation for this change

needs webrtc-audio-processing update

related: #158080

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from matthewbauer February 5, 2022 21:43
@jonringer
Copy link
Contributor Author

AFAIK, it shouldn't be an issue if this also goes into staging

@jonringer
Copy link
Contributor Author

I think I need the old webtrc-audio-processing. It doesn't seem to be api compatible in all regards with 0.3.1

@jonringer jonringer changed the title [staging-next] wip: gst_all_1.gst-plugins-bad: 1.18.5 -> 1.20.0 [staging-next] wip: gst_all_1.*: fix builds Feb 6, 2022
jtojnar
jtojnar reviewed Feb 6, 2022
View reviewed changes
pkgs/development/libraries/abseil-cpp/default.nix Outdated
patches = [
# Use CMAKE_INSTALL_FULL_{LIBDIR,INCLUDEDIR}
# https://github.com/abseil/abseil-cpp/pull/963
(fetchpatch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchpatch should be removed form attributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually need to restore the old version.

Dont remember which package, but other packages aren't api compatible with it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found it,

error: builder for '/nix/store/yjssm66bj004hhviri4akwc7gxwj3qcq-tensorflow-lite-2.5.0.drv' failed with exit code 2;
...
       > cordz_info.cc:(.text.unlikely+0x31): undefined reference to `absl::lts_20211102::Mutex::~Mutex()'
       > collect2: error: ld returned 1 exit status

@ofborg ofborg bot requested a review from andersk February 6, 2022 18:49
jtojnar
jtojnar reviewed Feb 6, 2022
View reviewed changes
pkgs/development/libraries/gstreamer/bad/default.nix Outdated
@@ -127,7 +127,7 @@ stdenv.mkDerivation rec {
ldacbt
libass
libkate
webrtc-audio-processing # webrtc
webrtc-audio-processing_1 # webrtc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to re-enable isac plug-in.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 6, 2022

Looks like bad depends on both the old and new w-a-p:

ext/webrtcdsp/meson.build:7:0: ERROR: Dependency "webrtc-audio-processing" not found, tried pkgconfig
ext/isac/meson.build:1:0: ERROR: Dependency "webrtc-audio-coding-1" not found, tried pkgconfig

That will be fun.

@jonringer
Copy link
Contributor Author

ext/webrtcdsp/meson.build:7:0: ERROR: Dependency "webrtc-audio-processing" not found, tried pkgconfig
ext/isac/meson.build:1:0: ERROR: Dependency "webrtc-audio-coding-1" not found, tried pkgconfig

Seems like meson is fine with both being there.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 6, 2022

Yeah, I imagine there might be symbol clashes if the two plug-ins are loaded at runtime.

@jonringer
Copy link
Contributor Author

Yeah, I imagine there might be symbol clashes if the two plug-ins are loaded at runtime.

Unless it's somehow able to determine the correct library, and link accordingly. However, this is probably an exceptionally rare case for build toolchains

@jonringer
Copy link
Contributor Author

I created a hydra job: https://hydra.jonringer.us/jobset/nixpkgs/gstreamer

@siraben
Copy link
Member

siraben commented Feb 6, 2022

Result of nixpkgs-review pr 158280 run on aarch64-darwin 1

28 packages marked as broken and skipped:
  • balsa
  • birdfont
  • font-manager
  • gnome-podcasts
  • gnvim
  • gnvim-unwrapped
  • kicad
  • kicad-small
  • kicad-unstable
  • kicad-unstable-small
  • lispPackages.cl-webkit2
  • lispPackages.nyxt
  • luakit
  • mopidy-musicbox-webclient
  • newsflash
  • pdfpc
  • python310Packages.kicad
  • python310Packages.wxPython_4_1
  • python39Packages.kicad
  • python39Packages.wxPython_4_1
  • qutebrowser
  • rednotebook
  • sayonara
  • setzer
  • timeline
  • webkitgtk
  • webkitgtk_4_1
  • wike
30 packages failed to build:
  • gssdp-tools
  • gst_all_1.gst-editing-services
  • gst_all_1.gst-plugins-bad
  • gst_all_1.gst-rtsp-server
  • gtk4
  • gtksourceview5
  • mopidy
  • mopidy-iris
  • mopidy-jellyfin
  • mopidy-local
  • mopidy-moped
  • mopidy-mopify
  • mopidy-mpd
  • mopidy-mpris
  • mopidy-muse
  • mopidy-podcast
  • mopidy-scrobbler
  • mopidy-somafm
  • mopidy-soundcloud
  • mopidy-subidy
  • mopidy-tunein
  • mopidy-youtube
  • mopidy-ytmusic
  • netease-cloud-music-gtk
  • pithos
  • python310Packages.kivy
  • python39Packages.kivy
  • rpiplay
  • termplay
  • wrapGAppsHook4
2 packages built:
  • abseil-cpp_202111
  • webrtc-audio-processing_1

jonringer
jonringer commented Feb 7, 2022
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
webrtc-audio-processing = callPackage ../development/libraries/webrtc-audio-processing { };
webrtc-audio-processing_1 = callPackage ../development/libraries/webrtc-audio-processing { };
webrtc-audio-processing_0_3 = callPackage ../development/libraries/webrtc-audio-processing/0.3.nix { };
# bump when majoring of packages have updated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# bump when majoring of packages have updated
# bump when majority of packages have updated

@jtojnar
Copy link
Contributor

jtojnar commented Feb 7, 2022

Opened an issue upstream: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1001

@jonringer
Copy link
Contributor Author

Opened an issue upstream: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1001

Thanks

@jonringer
Copy link
Contributor Author

jonringer commented Feb 7, 2022 •
edited

I started a new hydra eval as I reverted the ffmpeg default bump on staging-next, which was causing a bunch of overlapped failures.

@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python labels Feb 10, 2022
@ofborg ofborg bot requested review from dasj19, jtojnar and amaxine February 10, 2022 04:25
@jonringer
Copy link
Contributor Author

getting really weird behavior on some downstream dependencies of the bad plugin, going to just disable isac again and call it a day.

@github-actions github-actions bot removed 6.topic: python 6.topic: GNOME GNOME desktop environment and its underlying platform labels Feb 10, 2022
@jonringer
Copy link
Contributor Author

I think we can finish this on staging-next

@jonringer jonringer merged commit d01d083 into NixOS:staging-next Feb 10, 2022
@jonringer jonringer deleted the gst-bad branch February 10, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@andersk andersk Awaiting requested review from andersk

@piegamesde piegamesde Awaiting requested review from piegamesde

@hedning hedning Awaiting requested review from hedning

@FRidh FRidh Awaiting requested review from FRidh

@dasj19 dasj19 Awaiting requested review from dasj19

@jtojnar jtojnar Awaiting requested review from jtojnar

@amaxine amaxine Awaiting requested review from amaxine

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @jtojnar @siraben