Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Eliom ecosystem to 2016-01 #15833

Merged
merged 12 commits into from
Jun 4, 2016
Merged

Update the Eliom ecosystem to 2016-01 #15833

merged 12 commits into from
Jun 4, 2016

Conversation

FlorentBecker
Copy link
Contributor

@FlorentBecker FlorentBecker commented May 30, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vbgl, @nbp and @ericbmerritt to be potential reviewers

meta = with stdenv.lib; {
homepage = https://github.com/aantron/markup.ml/;
description = "A pair of best-effort parsers implementing the HTML5 and XML specifications";
license = licenses.bsd3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbgl
Copy link
Contributor

vbgl commented May 30, 2016

I believe that the claim in your last commit does not hold: eliom can work without PPX and with OCaml-4.01. That being said, I am not convinced that maintaining two eliom configurations (with and without PPX) is worth the trouble; so enabling eliom only on 4.02 may be the right choice.

Edit: after looking a little bit further, it seems easy to build eliom without PPX support. Here is the pre-configure hook that I tested in the eliom derivation. It builds fine (with ocaml-4.01); I did not test that eliom works well.

preConfigure = stdenv.lib.optionalString (!stdenv.lib.versionAtLeast ocamlVersion "4.02") ''
      export PPX=false
    '';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants