-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Eliom ecosystem to 2016-01 #15833
Conversation
By analyzing the blame information on this pull request, we identified @vbgl, @nbp and @ericbmerritt to be potential reviewers |
meta = with stdenv.lib; { | ||
homepage = https://github.com/aantron/markup.ml/; | ||
description = "A pair of best-effort parsers implementing the HTML5 and XML specifications"; | ||
license = licenses.bsd3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bsd2
might be more accurate. See https://github.com/aantron/markup.ml/blob/master/doc/LICENSE#L1
I believe that the claim in your last commit does not hold: eliom can work without PPX and with OCaml-4.01. That being said, I am not convinced that maintaining two eliom configurations (with and without PPX) is worth the trouble; so enabling eliom only on 4.02 may be the right choice. Edit: after looking a little bit further, it seems easy to build eliom without PPX support. Here is the pre-configure hook that I tested in the eliom derivation. It builds fine (with ocaml-4.01); I did not test that eliom works well.
|
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)