[WIP] soundux: init at 0.2.7 #160181

pasqui23 · 2022-02-15T15:42:16Z

Motivation for this change

Things done

Builds succeeds and the programs run.

Slabity · 2022-02-16T08:03:35Z

@pasqui23 - A short while ago I took the derivation from an older PR for soundux and fixed it up to compile and work on my system. It might help if you're going to try and get it brought into the repo:

{
  lib, stdenv, fetchFromGitHub, cmake, ninja, pkg-config, makeWrapper, wrapGAppsHook,
  libappindicator-gtk3, openssl, pipewire, pulseaudio, webkitgtk, xorg,
  libpulseaudio, libwnck3,
  downloaderSupport ? true, ffmpeg, youtube-dl
}:

let
  downloaderPath = lib.makeBinPath [ffmpeg youtube-dl ];
  # Soundux loads pipewire, pulse and libwnck optionally during runtime
  dynamicLibraries = lib.makeLibraryPath [libpulseaudio pipewire libwnck3 ];
in
stdenv.mkDerivation rec {
  pname = "soundux";
  version = "0.2.7";

  src = fetchFromGitHub {
    owner = "Soundux";
    repo = "Soundux";
    rev = version;
    fetchSubmodules = true;
    sha256 = "15kd9vl7inn8zm5cqzjkb6zb9xk2xxwpkm7fx1za3dy9m61sq839";
  };

  cmakeFlags = [ "-DCMAKE_BUILD_TYPE=Release" ];

  dontWrapGApps = true;

  installPhase = ''
    mkdir -p $out/opt $out/bin
    cp -r dist soundux-${version} $out/opt
  '';

  postFixup = ''
    makeWrapper $out/opt/soundux-${version} $out/bin/soundux \
      --prefix LD_LIBRARY_PATH ":" ${dynamicLibraries} \
      "''${gappsWrapperArgs[@]}" \
      ${lib.optionalString downloaderSupport "--prefix PATH \":\" " + downloaderPath}
  '';

  nativeBuildInputs = [ cmake ninja pkg-config makeWrapper wrapGAppsHook ];
  buildInputs = [
    libappindicator-gtk3
    openssl
    pipewire
    pulseaudio
    webkitgtk
    xorg.libX11
    xorg.libXtst
  ];

  meta = with lib; {
    homepage = "https://soundux.rocks/";
    description = "cross-platform soundboard";
    license = licenses.gpl3Only;
    platforms = platforms.linux;
  };
}

pasqui23 · 2022-02-16T10:47:03Z

@Slabity Sorry even with your fix still does not compile

Slabity · 2022-02-17T04:37:21Z

@Slabity Sorry even with your fix still does not compile

Strange. That derivation builds for me and lets me run it without any issue.

pasqui23 · 2022-02-23T20:10:47Z

Ok @Slabity my mistake. Now it builds and run perfectly

yshym

Package file should be formatted with nixpkgs-fmt

yshym · 2022-04-09T19:12:10Z

pkgs/applications/audio/soundux/default.nix

+    mkdir -p $out/opt $out/bin
+    cp -r dist soundux-${version} $out/opt
+  '';
+


Would you please add desktopItem attribute here (check discord package for example)

You'll also need to create share directory and create a symlink to it like here

pkgs/applications/audio/soundux/default.nix

yshym · 2022-04-10T12:44:35Z

pkgs/applications/audio/soundux/default.nix

+  buildInputs = [
+    libappindicator-gtk3
+    openssl
+    pipewire
+    pulseaudio
+    webkitgtk
+    xorg.libX11
+    xorg.libXtst
+  ];


Suggested change

buildInputs = [

libappindicator-gtk3

openssl

pipewire

pulseaudio

webkitgtk

xorg.libX11

xorg.libXtst

];

buildInputs = with xorg; [

libappindicator-gtk3

openssl

pipewire

pulseaudio

webkitgtk

libX11

libXtst

];

dali99

@Slabity What was your fix? as far as I can tell what you posted is just, exactly my package 4943cd2 but with the maintainer field removed.

The reason the original PR wasn't merged was because the libraries used needed to be devendored, you'll have to do that as well if you want this merged.

In it's current form this is 99% my work anyways though lol, and most of the things commented on previously were already covered by the final version in the aforementiond PR (#129571)

I applaud you for picking up the mantle and don't at all mind. But you should be careful about these things in the future since it's important that you actually hold legal copyright over the work you try to commit. (And the line for how much you can copy, and how complex that can be is generally fairly poorly defined)

Slabity · 2022-04-17T19:38:02Z

@dali99 - Uh... I think I screwed up my copy-paste because I definitely added a lot more dependencies in mine to fix some linking issues and get all the additional features I wanted. And it doesn't look like I removed the maintainer field. Here's what I have in my repo at the moment:

{
  lib, stdenv, fetchFromGitHub, cmake, ninja, pkg-config, makeWrapper, wrapGAppsHook,
  libappindicator-gtk3, pcre, openssl, pipewire, pulseaudio, webkitgtk, xorg, utillinux,
  libpulseaudio, libwnck3, libselinux, libsepol, libthai, libdatrie,
  libxkbcommon, epoxy, dbus_tools,
  downloaderSupport ? true, ffmpeg, youtube-dl
}:

let
  downloaderPath = lib.makeBinPath [ffmpeg youtube-dl ];
  # Soundux loads pipewire, pulse and libwnck optionally during runtime
  dynamicLibraries = lib.makeLibraryPath [libpulseaudio pipewire libwnck3 ];
in
stdenv.mkDerivation rec {
  pname = "soundux";
  version = "0.2.7";

  src = fetchFromGitHub {
    owner = "Soundux";
    repo = "Soundux";
    rev = version;
    fetchSubmodules = true;
    sha256 = "15kd9vl7inn8zm5cqzjkb6zb9xk2xxwpkm7fx1za3dy9m61sq839";
  };

  cmakeFlags = [ "-DCMAKE_BUILD_TYPE=Release" ];

  dontWrapGApps = true;

  installPhase = ''
    mkdir -p $out/opt $out/bin
    cp -r dist soundux-${version} $out/opt
  '';

  postFixup = ''
    makeWrapper $out/opt/soundux-${version} $out/bin/soundux \
      --prefix LD_LIBRARY_PATH ":" ${dynamicLibraries} \
      "''${gappsWrapperArgs[@]}" \
      ${lib.optionalString downloaderSupport "--prefix PATH \":\" " + downloaderPath}
  '';

  nativeBuildInputs = [ cmake ninja pkg-config makeWrapper wrapGAppsHook ];
  buildInputs = [
    libappindicator-gtk3
    openssl
    libselinux
    libsepol
    libthai
    libdatrie
    utillinux
    pcre
    pipewire
    pulseaudio
    webkitgtk
    xorg.libX11
    xorg.libXtst
    xorg.libXdmcp
    libxkbcommon
    epoxy
    dbus_tools
  ];

  meta = with lib; {
    homepage = "https://soundux.rocks/";
    description = "cross-platform soundboard";
    license = licenses.gpl3Only;
    platforms = platforms.linux;
    maintainers = with maintainers; [ dandellion ];
  };
}

Sorry for the mixup, I wasn't intending to get my changes committed at all. I just happened to see this PR and thought I'd link to the older one since it was closer to working.

dali99 · 2022-04-17T19:47:58Z

No worries, everything after the first section was mainly aimed at @pasqui23 anyways :) I was just generally wondering what you did to fix it!

dali99

By devendoring we refer to building without these libraries coming from the soundux source: https://github.com/Soundux/Soundux/tree/0.2.7/lib and rather being packaged directly in nixpkgs

nixos-discourse · 2022-04-25T10:20:56Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/827

gador

Please rebase. If you want me to check again later and build the package, give me a ping.

gador · 2022-04-25T12:24:36Z

pkgs/applications/audio/soundux/default.nix

+    description = "cross-platform soundboard";
+    license = licenses.gpl3Only;
+    platforms = platforms.linux;
+    maintainers = with maintainers; [ dandellion ];


Is it intentional that you are not listed as maintainer?

Listing other people without their approval is not allowed. Please change that.

soundux: made it work(?) soundux: added desktop file soundux: formatting

SuperSandro2000 · 2022-04-25T15:23:21Z

pkgs/applications/audio/soundux/default.nix

+    makeWrapper $out/opt/soundux-${version} $out/bin/soundux \
+      --prefix LD_LIBRARY_PATH ":" ${dynamicLibraries} \
+      "''${gappsWrapperArgs[@]}" \
+      ${lib.optionalString downloaderSupport "--prefix PATH \":\" " + downloaderPath}


Suggested change

${lib.optionalString downloaderSupport "--prefix PATH \":\" " + downloaderPath}

${lib.optionalString downloaderSupport "--prefix PATH \":\" ${lib.makeBinPath [ ffmpeg youtube-dl ]}"}

SuperSandro2000 · 2022-04-25T15:24:09Z

pkgs/applications/audio/soundux/default.nix

+    makeWrapper $out/opt/soundux-${version} $out/bin/soundux \
+      --prefix LD_LIBRARY_PATH ":" ${dynamicLibraries} \


Suggested change

makeWrapper $out/opt/soundux-${version} $out/bin/soundux \

--prefix LD_LIBRARY_PATH ":" ${dynamicLibraries} \

# Soundux loads pipewire, pulse and libwnck optionally during runtime

makeWrapper $out/opt/soundux-${version} $out/bin/soundux \

--prefix LD_LIBRARY_PATH ":" ${lib.makeLibraryPath [ libpulseaudio pipewire libwnck3 ]} \

SuperSandro2000 · 2022-04-25T15:24:13Z

pkgs/applications/audio/soundux/default.nix

+let
+  downloaderPath = lib.makeBinPath [ ffmpeg youtube-dl ];
+  # Soundux loads pipewire, pulse and libwnck optionally during runtime
+  dynamicLibraries = lib.makeLibraryPath [ libpulseaudio pipewire libwnck3 ];
+in
+stdenv.mkDerivation rec {


Suggested change

let

downloaderPath = lib.makeBinPath [ ffmpeg youtube-dl ];

# Soundux loads pipewire, pulse and libwnck optionally during runtime

dynamicLibraries = lib.makeLibraryPath [ libpulseaudio pipewire libwnck3 ];

in

stdenv.mkDerivation rec {

stdenv.mkDerivation rec {

SuperSandro2000 · 2022-04-25T15:25:02Z

pkgs/applications/audio/soundux/default.nix

+    owner = "Soundux";
+    repo = "Soundux";
+    rev = version;
+    fetchSubmodules = true;


Vendoring so many libraries is not great.

SuperSandro2000 · 2022-04-25T15:25:30Z

pkgs/applications/audio/soundux/default.nix

+  installPhase = ''
+    mkdir -p $out/opt $out/bin $out/share
+    cp -r dist soundux-${version} $out/opt
+    ln -s "${desktopItem}/share/applications" $out/share/


Please use copyDesktopItems.

SuperSandro2000 · 2022-04-25T15:25:39Z

pkgs/applications/audio/soundux/default.nix

+
+  installPhase = ''
+    mkdir -p $out/opt $out/bin $out/share
+    cp -r dist soundux-${version} $out/opt


Does this need to be opt?

SuperSandro2000 · 2022-04-25T15:26:06Z

pkgs/applications/audio/soundux/default.nix

+    description = "cross-platform soundboard";
+    license = licenses.gpl3Only;
+    platforms = platforms.linux;
+    maintainers = with maintainers; [ dandellion ];


Listing other people without their approval is not allowed. Please change that.

dali99

Your devendoring commit does not devendor.

See my prior comment on what we mean when we say that

gador · 2022-04-26T09:49:21Z

Result of nixpkgs-review pr 160181 run on x86_64-linux 1

1 package failed to build:

soundux

PAI5REECHO · 2022-05-05T00:57:44Z

I couldn't get this to run due to some EGL issues:

[00:56:35] [success] Config read
[00:56:35] [success] LibWnck found - Icon support is enabled

(soundux-0.2.7:342196): Gdk-WARNING **: 20:56:35.822: Failed to read portal settings: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface ?org.freedesktop.portal.Settings? on object at path /org/freedesktop/portal/desktop

(soundux-0.2.7:342196): Wnck-WARNING **: 20:56:35.841: libwnck is designed to work in X11 only, no valid display found
[00:56:35] [warning] Failed to get default screen!
[00:56:35] [failure] Could not create IconFetcher instance
[00:56:35] [message] Connected to PipeWire ("pipewire-0") on version "0.3.49"
[00:56:36] [warning] Path "/home/me/audio-clips" does not exist
[00:56:36] [message] Using DISPLAY :0
[00:56:36] [warning] Failed to find iconPath for tray icon
Could not determine the accessibility bus address

(WebKitWebProcess:342222): Gdk-WARNING **: 20:56:36.348: Failed to read portal settings: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.portal.Settings” on object at path /org/freedesktop/portal/desktop
EGLDisplay Initialization failed: EGL_NOT_INITIALIZED
Cannot create EGL context: invalid display (last error: EGL_SUCCESS)

milahu · 2022-05-14T11:00:56Z

EGLDisplay Initialization failed: EGL_NOT_INITIALIZED

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] soundux: init at 0.2.7 #160181

[WIP] soundux: init at 0.2.7 #160181

pasqui23 commented Feb 15, 2022 •

edited

Slabity commented Feb 16, 2022

pasqui23 commented Feb 16, 2022

Slabity commented Feb 17, 2022

pasqui23 commented Feb 23, 2022

yshym left a comment •

edited

yshym Apr 9, 2022

yshym Apr 9, 2022

yshym Apr 10, 2022

dali99 left a comment

Slabity commented Apr 17, 2022

dali99 commented Apr 17, 2022 •

edited

dali99 left a comment

nixos-discourse commented Apr 25, 2022

gador left a comment

gador Apr 25, 2022

SuperSandro2000 Apr 25, 2022

SuperSandro2000 Apr 25, 2022

SuperSandro2000 Apr 25, 2022

SuperSandro2000 Apr 25, 2022

SuperSandro2000 Apr 25, 2022

SuperSandro2000 Apr 25, 2022

SuperSandro2000 Apr 25, 2022

SuperSandro2000 Apr 25, 2022

dali99 left a comment

gador commented Apr 26, 2022

PAI5REECHO commented May 5, 2022

milahu commented May 14, 2022

NickCao commented Jan 26, 2023

	${lib.optionalString downloaderSupport "--prefix PATH \":\" " + downloaderPath}
	${lib.optionalString downloaderSupport "--prefix PATH \":\" ${lib.makeBinPath [ ffmpeg youtube-dl ]}"}

		makeWrapper $out/opt/soundux-${version} $out/bin/soundux \
		--prefix LD_LIBRARY_PATH ":" ${dynamicLibraries} \

[WIP] soundux: init at 0.2.7 #160181

[WIP] soundux: init at 0.2.7 #160181

Conversation

pasqui23 commented Feb 15, 2022 • edited

Motivation for this change

Things done

Slabity commented Feb 16, 2022

pasqui23 commented Feb 16, 2022

Slabity commented Feb 17, 2022

pasqui23 commented Feb 23, 2022

yshym left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dali99 left a comment

Choose a reason for hiding this comment

Slabity commented Apr 17, 2022

dali99 commented Apr 17, 2022 • edited

dali99 left a comment

Choose a reason for hiding this comment

nixos-discourse commented Apr 25, 2022

gador left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dali99 left a comment

Choose a reason for hiding this comment

gador commented Apr 26, 2022

PAI5REECHO commented May 5, 2022

milahu commented May 14, 2022

NickCao commented Jan 26, 2023

pasqui23 commented Feb 15, 2022 •

edited

yshym left a comment •

edited

dali99 commented Apr 17, 2022 •

edited