Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuntox: init at 0.0.10 #160548

Merged
merged 1 commit into from
Feb 20, 2022
Merged

tuntox: init at 0.0.10 #160548

merged 1 commit into from
Feb 20, 2022

Conversation

willcohen
Copy link
Contributor

@willcohen willcohen commented Feb 18, 2022

Motivation for this change

Completes including package for #32823. Does not include adding a nixos service.
@fgaz

While the upstream author builds binaries for linux, macOS is not included, nor does it appear on homebrew.

One specific use case for this package is to enable easier use of https://elpa.gnu.org/packages/crdt.html across the public internet.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@willcohen
Copy link
Contributor Author

Result of nixpkgs-review pr 160548 run on x86_64-linux 1

1 package built:
  • tuntox

@willcohen
Copy link
Contributor Author

Result of nixpkgs-review pr 160548 run on x86_64-darwin 1

1 package built:
  • tuntox

@willcohen
Copy link
Contributor Author

Just forcepushed to bypass check since passthru.tests was failing. I would normally want to put a little simple version check or something, but tuntox provides output only to stderr, so I can't even do a quick grep on the help message correctly.

@willcohen
Copy link
Contributor Author

willcohen commented Feb 18, 2022

@fgaz sounds good re #32823. I think I got all the issues worked out here. There were some fixed derivation hash issues (I think stemming from including keepDotGit, which I thought I needed to deal with the Makefile, but turned out to be unnecessary). Let me know if there's anything else that needs to go here! Thanks!

@willcohen
Copy link
Contributor Author

willcohen commented Feb 18, 2022

@adisbladis @jwiegley although not directly depended on by emacs, adding this would simplify use of crdt.el, particularly for the darwin users who can't just download the prebuilt binaries.

pkgs/tools/networking/tuntox/default.nix Outdated Show resolved Hide resolved
@willcohen
Copy link
Contributor Author

Many thanks @ehmry!

@willcohen willcohen deleted the tuntox branch February 20, 2022 14:19
@gjedeer
Copy link

gjedeer commented Feb 21, 2022

tuntox provides output only to stderr, so I can't even do a quick grep on the help message correctly

@willcohen please open an issue or PR then. I'd be happy to make tuntox a good unix citizen.

@willcohen
Copy link
Contributor Author

Issue at gjedeer/tuntox#68!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants