Neovim darwin fixes #16159
Merged
Neovim darwin fixes #16159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @garbas, @joachifm and @the-kenny to be potential reviewers |
matthewbauer
force-pushed
the
neovim-darwin-fixes
branch
from
24dc076
to
a88e583
Compare
matthewbauer
force-pushed
the
neovim-darwin-fixes
branch
from
a88e583
to
ff03283
Compare
clang has some things considered “warnings” that gcc doesn’t so it is necessary to set “-Wno-error” to build under clang.
fixes NixOS#16152 The cmake script had trouble finding the lua paths, this sets them using “luaPackages.getLuaPath” and “luaPackages.getLuaCPath”.
matthewbauer
force-pushed
the
neovim-darwin-fixes
branch
from
ff03283
to
e0884e8
Compare
|
Lack of build space is causing travis to break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These are all necessary to get nevoid to build.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)