Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yuview: init at 2.12.1 #162765

Merged
merged 1 commit into from
Mar 21, 2022
Merged

yuview: init at 2.12.1 #162765

merged 1 commit into from
Mar 21, 2022

Conversation

Leixb
Copy link
Member

@Leixb Leixb commented Mar 4, 2022

Motivation for this change

YUView is a Free and Open Source Cross Platform YUV Viewer with an advanced analytics toolset.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Mar 6, 2022

@ofborg eval

@vdot0x23
Copy link
Contributor

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/467

pkgs/top-level/qt5-packages.nix Outdated Show resolved Hide resolved
#define YUVIEW_VERSION "Unknown"
#endif

-#ifndef YUVIEW_HASH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we force disable this by not defining YUVIEW_HASH?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YUVIEW_HASH is defined in the qt project file:

https://github.com/IENT/YUView/blob/168a55cb980f78bad907a28e2b7a0a2da84b1622/YUViewLib/YUViewLib.pro#L41-L44

We could patch it and remove it there, but I think the current patch is more clear on what it does.

pkgs/applications/video/yuview/default.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants