Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

river: copy wayland-session from contrib #163391

Closed
wants to merge 1 commit into from

Conversation

edrex
Copy link
Contributor

@edrex edrex commented Mar 8, 2022

Description of changes

Copies contrib/sway.desktop to share/wayland-sessions/ and declares a providedSession for NixOS. This should allow starting river from eg lightdm by adding the river package to services.xserver.displayManager.sessionPackages.

@06kellyjac
Copy link
Member

06kellyjac commented Mar 9, 2022

Description should say Copies contrib/river.desktop. Other than that looks good. I'll try it out in a nixos VM quickly


Update. I've been trying to get sway to play ball first as a control before checking river but even sway is not working well

@edrex
Copy link
Contributor Author

edrex commented Mar 11, 2022

I just rebooted and took the opportunity to test with lightdm, and neither river's entry nor sway's would start for me. Need to investigate further.

@edrex edrex marked this pull request as draft March 11, 2022 02:57
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2022
@m-bdf
Copy link
Contributor

m-bdf commented May 2, 2023

This works for me with ReGreet, just need to set services.xserver.displayManager.sessionPackages = [ pkgs.river ].

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 2, 2023
@06kellyjac
Copy link
Member

@m-bdf thanks for testing this.
Out of interest do you use ReGreet with cage or sway?


Looks like this was actually handled in #203482 so I'll close this PR now

@06kellyjac 06kellyjac closed this May 4, 2023
@m-bdf
Copy link
Contributor

m-bdf commented May 4, 2023

Oh yeah indeed, I just stumbled across this PR and decided to give it a try without looking further :)

I just enabled the ReGreet module with its default config, so using cage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants