New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.dunamai: init at 1.10.0 #164784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please squash the commit? But keep the one for maintainer-list.nix
.
9d85c32
to
c7df6b0
Compare
@fabaff Done. |
The commit message for
|
c7df6b0
to
131ecf2
Compare
Done. |
Result of 2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
-
meta.description
is set and fits guidelines -
meta.license
fits upstream license -
meta.maintainers
is set - package builds (see python3Packages.dunamai: init at 1.10.0 #164784 (comment))
- all depending packages build
- tested on x86_64
...ew/pr-164784]$ ./results/python310Packages.dunamai/bin/dunamai
usage: dunamai [-h] {from,check} ...
dunamai: error: the following arguments are required: command
Looks good to me.
Thanks @jmgilman for your first package. |
Description of changes
Adds the dunamai python package.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes