Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dunamai: init at 1.10.0 #164784

Merged
merged 2 commits into from Mar 22, 2022
Merged

Conversation

jmgilman
Copy link
Contributor

Description of changes

Adds the dunamai python package.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash the commit? But keep the one for maintainer-list.nix.

@jmgilman
Copy link
Contributor Author

Can you please squash the commit? But keep the one for maintainer-list.nix.

@fabaff Done.

@fabaff
Copy link
Member

fabaff commented Mar 21, 2022

The commit message for maintainer-list.nix should not mention a Python module. Could you do a git commit --amend?

maintainers: add @jmgilman

@jmgilman
Copy link
Contributor Author

The commit message for maintainer-list.nix should not mention a Python module. Could you do a git commit --amend?

maintainers: add @jmgilman

Done.

@fabaff
Copy link
Member

fabaff commented Mar 22, 2022

Result of nixpkgs-review pr 164784 run on x86_64-linux 1

2 packages built:
  • python310Packages.dunamai
  • python39Packages.dunamai

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.maintainers is set
  • package builds (see python3Packages.dunamai: init at 1.10.0 #164784 (comment))
  • all depending packages build
  • tested on x86_64
...ew/pr-164784]$ ./results/python310Packages.dunamai/bin/dunamai 
usage: dunamai [-h] {from,check} ...
dunamai: error: the following arguments are required: command

Looks good to me.

@fabaff fabaff merged commit 5145440 into NixOS:master Mar 22, 2022
@fabaff
Copy link
Member

fabaff commented Mar 22, 2022

Thanks @jmgilman for your first package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants