nixos/wireguard: fix dependencies on network-related targets #165474
Conversation
wireguard-${name}.service only sets up interfaces and doesn't need to
connect to the Internet.
See sections of these three network-related targets in systemd
manuals[1][2] for more information.
Also, remove the redundant multi-user.target in peer units.
Fixes NixOS#142152
[1]: https://www.freedesktop.org/software/systemd/man/systemd.special.html
[2]: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
|
cc @grahamc and @ericsagnes as you are the authors of the part I change. |
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
|
Reminder: Please review! This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually. |
|
I'd prefer if someone who is more familiar with the module takes a look at this first. @grahamc could you check if this looks good to you? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
@lheckemann Could you add an approval since we have discussed on matrix. A merge will be better. :) |
|
Sorry, I missed that! |
Description of changes
wireguard-${name}.service only sets up interfaces and doesn't need to
connect to the Internet.
See sections of these three network-related targets in systemd
manuals1 for more information.
Also, remove the redundant multi-user.target in peer units.
Fixes #142152
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes