Datefudge #16610
Datefudge #16610
Conversation
|
By analyzing the blame information on this pull request, we identified @wkennington, @edolstra and @vcunat to be potential reviewers |
| @@ -0,0 +1,40 @@ | |||
| { stdenv, fetchgit, dpkg }: | |||
There was a problem hiding this comment.
I don't think dpkg is actually needed?
|
That test is working for me on NixOS: What distribution is Nix installed on? Perhaps it has something to do with permissions. |
|
@matthewbauer: it works for me on NixOS too, so at least there we could get things working again. Indeed one of the things the Nix recipe does is change the installer which involves a small permission related snippet. I guess the dpkg can go - in the Makefile this only serves to get the version number from the Debian metadata also included. |
|
As the PR is, it seems not to fix the expiration problem. I suppose it will be best to just disable that single test, at least for now. |
- disable a test that started failing due to date expiration, see #16610 - bash doesn't need adding - defining patchPhase was overriding passed postPatch and patches
|
I disabled that test on staging: 17faf91. |
|
Removed the dpkg. |
|
It was indeed a rights issue. Fixed. Should be ready to merge now. Should I try to reenable this test in GnuTLS? |
|
@leenaars We should definitely do that but probably in a separate PR on staging so we don't have massive rebuild issues again. |
|
I've heard this was ready to merge :) |
Motivation for this change
This pull request is not meant to be merged without further work.
Datefudge is a tool for faking system time used by e.g. recent gnutls for testing what happens at certain times. There is an updated version of gnutls currently in nixpkgs unstable, which breaks due to the absence of datefudge.
Given that it is a simple but useful tool anyway (it is used by other applications like gitlab during tests as well), I'm trying to add it to nixpkgs. Currently the datefudge library gets builds and the application gets installed. It is a small wrapper app written in shell, which calls the compiled library.
Subsequently however one gets a segmentation error when running a test e.g.
something like:
The tool is 13 years old, and runs apparently flawlessly on Debian, Arch, etc.
Currently gnutls, and everything that depends on it, might be broken in unstable without datefudge. Not a happy thought. Is there anyone that would have the good heart to have a look at what could be wrong with the datefudge "recipe"?
Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)